Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@cmbartschat
Copy link
Contributor

@cmbartschat cmbartschat commented Jun 8, 2025

What is it?

  • Bug

Description

When deploying to vercel I saw an "Invalid route source pattern" error.

This pattern seems to have been modified in f0388d4#diff-c6a948ae10892b24f31a2545d6eb120f1a47f4f338221fa087eff4e7688e34b9R13 which dropped the parenthesis around the .*, which seem to be required. After this change I was able to deploy, and see the correct cache headers:

Screenshot showing response headers for a /build/ response from vercel, containing public, max-age=31536000, s-maxage=31536000, immutable

@cmbartschat cmbartschat requested a review from a team as a code owner June 8, 2025 03:35
@changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2025

🦋 Changeset detected

Latest commit: 5af3cbc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
create-qwik Patch
@builder.io/qwik Patch
@builder.io/qwik-city Patch
eslint-plugin-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 8, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7663
npm i https://pkg.pr.new/@builder.io/qwik-city@7663
npm i https://pkg.pr.new/eslint-plugin-qwik@7663
npm i https://pkg.pr.new/create-qwik@7663

commit: 98a5392

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 857b0ef

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @cmbartschat

@gioboa gioboa requested a review from wmertens June 9, 2025 06:55
gioboa
gioboa previously approved these changes Jun 24, 2025
@gioboa gioboa changed the title fix(vercel) vercel.json source pattern fix(starter): fix up vercel.json source pattern Jun 25, 2025
@gioboa gioboa changed the title fix(starter): fix up vercel.json source pattern fix(starters): fix up vercel.json source pattern Jun 25, 2025
@gioboa gioboa enabled auto-merge (squash) June 25, 2025 07:50
@gioboa gioboa merged commit feee2f5 into QwikDev:main Jun 25, 2025
17 checks passed
@github-actions github-actions bot mentioned this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants