Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@SKhajeh
Copy link
Contributor

@SKhajeh SKhajeh commented Jun 23, 2025

After testing locally, it seems that the routeLoader$'s callback needs to be async as well.

What is it?

  • Docs / tests / types / typos

Description

Initially I was confused when the on-site provided example didn't work in my browser.
Then tried it locally, didn't work as well(the routeLoader$ still blocked rendering).
Tried it again with both the functions asynced, and it worked as described by the docs.

Checklist

  • I made corresponding changes to the Qwik docs

After testing locally, it seems that the routeLoader$'s callback needs to be async as well.
@SKhajeh SKhajeh requested a review from a team as a code owner June 23, 2025 15:37
@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2025

⚠️ No Changeset found

Latest commit: 5ba83a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 5ba83a1

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice catch @SKhajeh

@gioboa gioboa changed the title Update index.mdx docs: fix up routeLoader$ example Jun 24, 2025
@gioboa gioboa merged commit e97a8ec into QwikDev:main Jun 24, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants