Closed
Conversation
Collaborator
Author
|
Just added support for 32 bits windows (with attach mode too) in same branch |
|
I have had to make the following change to make it work on my end: diff --git a/tools/QBDIPreload/CMakeLists.txt b/tools/QBDIPreload/CMakeLists.txt
index 5f24c33..a6c1f6f 100644
--- a/tools/QBDIPreload/CMakeLists.txt
+++ b/tools/QBDIPreload/CMakeLists.txt
@@ -2,11 +2,11 @@ set(SOURCES "")
if((${OS} STREQUAL "linux") OR (${OS} STREQUAL "android"))
set(SOURCES ${SOURCES} "src/linux_preload.c")
-elseif(WIN32)
+elseif(${OS} STREQUAL "win")
if(${ARCH} STREQUAL "X86")
set(SOURCES ${SOURCES} "src/win_preload.c" "src/trampoline_x86.asm")
set_source_files_properties("src/trampoline_x86.asm" PROPERTIES COMPILE_FLAGS "/safeseh")
- elseif(${ARCH} STREQUAL "X86-64")
+ elseif(${ARCH} STREQUAL "X86_64")
set(SOURCES ${SOURCES} "src/win_preload.c" "src/trampoline_x64.asm")
endif()
elseif(${OS} STREQUAL "macOS")Otherwise, I was getting the following error: |
Member
|
move to #227 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Windows QBDIPreload x86-64 in 2 modes: