Thanks to visit codestin.com
Credit goes to github.com

Skip to content

(WIP) Add Sampler V2 #11264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 63 commits into from
Closed

(WIP) Add Sampler V2 #11264

wants to merge 63 commits into from

Conversation

@t-imamichi
Copy link
Member

@t-imamichi t-imamichi commented Nov 17, 2023 •
edited
Loading

Summary

This is a follow-up of #11227 and it will rebase onto main once #11227 is merged.
This PR introduces BaseSamplerV2 and a reference implementation StatevectorSampler (tentative name) to realize the following RFCS

TODOs

Note: I might do a force push for the time being.

Details and comments

@coveralls
Copy link

coveralls commented Nov 20, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7456384737

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 87.51%
Totals Coverage Status
Change from base Build 7453493244: -0.05%
Covered Lines: 60345
Relevant Lines: 68958
💛 - Coveralls

@t-imamichi t-imamichi force-pushed the sampler-v2 branch 2 times, most recently from 45cbd4b to b81f658 Compare November 21, 2023 10:06
@ikkoham ikkoham added this to the 1.0.0 milestone Nov 28, 2023
This was referenced Jan 9, 2024
Merged
Merged
@t-imamichi
Copy link
Member Author

This PR will be updated or a new PR will be made based on #11524 and #11529

@kt474 kt474 mentioned this pull request Jan 11, 2024
Closed
@t-imamichi
Copy link
Member Author

#11566 supersedes

@t-imamichi t-imamichi closed this Jan 15, 2024
@t-imamichi t-imamichi mentioned this pull request Jan 15, 2024
Merged
@t-imamichi t-imamichi deleted the sampler-v2 branch January 19, 2024 01:14
@t-imamichi t-imamichi restored the sampler-v2 branch February 14, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

priority: high

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@t-imamichi @coveralls @1ucian0 @ikkoham @ihincks