Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump MSRV to Rust 1.85, Edition to 2024, and PyO3 to 0.26 #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Oct 24, 2025
Merged

Bump MSRV to Rust 1.85, Edition to 2024, and PyO3 to 0.26 #1510

merged 20 commits into from
Oct 24, 2025

Conversation

@IvanIsCoding
Copy link
Collaborator

@IvanIsCoding IvanIsCoding commented Sep 21, 2025 •
edited
Loading

This PR:

  • Bumps the MSRV to 1.85.1. Currently, the latest version is 1.90. Debian settled on 1.85.1 so I think it's a good starting point compared to 1.79. 1.85 is also the first version that ships with Edition 2024.
  • Migrates to Rust Edition 2024. The migration was done with cargo fix --edition.
  • Updates PyO3 to 0.26. This required many small mechanical changes to get rid of deprecation warnings
  • Bumps dependencies to newer versions. Now we can have dependencies with MSRV >= 1.79.

@IvanIsCoding IvanIsCoding changed the title [WIP] Bump MSRV to Rust 1.85, Edition to 2024, and PyO3 to 0.26 Bump MSRV to Rust 1.85, Edition to 2024, and PyO3 to 0.26 Sep 21, 2025
@IvanIsCoding IvanIsCoding marked this pull request as ready for review September 21, 2025 21:45
@IvanIsCoding IvanIsCoding added the dependencies Pull requests that update a dependency file label Sep 21, 2025
@IvanIsCoding IvanIsCoding added this to the 0.18.0 milestone Sep 21, 2025
@coveralls
Copy link

coveralls commented Sep 21, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 18639575611

Details

  • 440 of 460 (95.65%) changed or added relevant lines in 41 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 94.186%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rustworkx-core/src/dag_algo.rs 0 1 0.0%
rustworkx-core/src/err.rs 0 1 0.0%
rustworkx-core/src/generators/random_graph.rs 1 2 50.0%
src/dot_parser/mod.rs 7 9 77.78%
src/graph.rs 61 63 96.83%
src/union.rs 1 3 33.33%
src/iterators.rs 14 18 77.78%
src/graphml.rs 2 9 22.22%
Files with Coverage Reduction New Missed Lines %
rustworkx-core/src/generators/random_graph.rs 2 69.81%
Totals Coverage Status
Change from base Build 18637670573: -0.01%
Covered Lines: 18272
Relevant Lines: 19400
💛 - Coveralls

@IvanIsCoding IvanIsCoding mentioned this pull request Oct 13, 2025
Merged
mtreinish
mtreinish reviewed Oct 15, 2025
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only made it about half way through the files so far, but I've got to step away for today. So far it seems mostly straightforward. I do wish you had done this as a few separate PRs as it would have been simpler to review each logical change in isolation. I only have one comment so far about the macro usage changes in edition 2024. We don't need the macro expr changes because the new behavior in 2024 shouldn't effect our macros.

@IvanIsCoding
Copy link
Collaborator Author

IvanIsCoding commented Oct 15, 2025

I will fix the macros but: every single PR conflicts with edition 2024 and PyO3 0.26. So it was on the convenience of the author vs burden of the reviewer.

hopefully we merge this soon, sorry for the huge delta. But PyO3 renamed their most common struct

mtreinish
mtreinish approved these changes Oct 24, 2025
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've finished going through this now. All the changes are fairly mechanical thanks for the quick update on the macro thing, and thanks for doing this, sorry about the delay in reviewing it.

@mtreinish mtreinish added this pull request to the merge queue Oct 24, 2025
Merged via the queue into Qiskit:main with commit d1b43b6 Oct 24, 2025
60 of 66 checks passed
@IvanIsCoding IvanIsCoding mentioned this pull request Oct 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

0.18.0

Development

Successfully merging this pull request may close these issues.

3 participants

@IvanIsCoding @coveralls @mtreinish