Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add tree option for FileSource2 AddFile function #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jose-luis-rs merged 1 commit into from
Oct 31, 2024
Merged

Add tree option for FileSource2 AddFile function #1082

jose-luis-rs merged 1 commit into from
Oct 31, 2024

Conversation

@YanzhaoW
Copy link
Contributor

@YanzhaoW YanzhaoW commented Oct 23, 2024 •
edited
Loading

New feature

FileSource2 now can add the input file with only root tree together with normal input files.

Example:

auto filesource = std::make_unique<R3B::FileSource2>();

// for normal input files:
filesource->AddFile("normal.root");

// for input files containing only root trees:
filesource->AddFile("only_tree.root", true);

@deshaJM Could you test this out and see whether it could solve your problem?

Checklist:

@YanzhaoW YanzhaoW force-pushed the edwin_filesource_update branch 10 times, most recently from 721c95f to a6a23de Compare October 25, 2024 12:58
@deshaJM
Copy link

deshaJM commented Oct 28, 2024

I tested the recent changes, and they resolved my issue. The digitizer now correctly handles the second simulation file created once the first file reaches its maximum size, labeled with _1.root.

@YanzhaoW
Add tree option for FileSource2 AddFile
b7a29ea 
Add a new feature of FileSource2 that can specify each individual input
file with or without tree option.
@YanzhaoW YanzhaoW force-pushed the edwin_filesource_update branch from 23d6c6a to b7a29ea Compare October 28, 2024 16:39
@YanzhaoW
Copy link
Contributor Author

YanzhaoW commented Oct 31, 2024

Hi, @jose-luis-rs

This PR is ready to be merged.

@jose-luis-rs jose-luis-rs merged commit 2f6c548 into R3BRootGroup:dev Oct 31, 2024
@YanzhaoW YanzhaoW deleted the edwin_filesource_update branch November 1, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YanzhaoW @deshaJM @jose-luis-rs