Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Simplify code. #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ghislainfourny wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Simplify code. #1394

ghislainfourny wants to merge 6 commits into from

Conversation

@ghislainfourny
Copy link
Member

@ghislainfourny ghislainfourny commented Nov 3, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Test Results (qt3tests)

RumbleDB, XQuery parser
Test Suite Passing Failing Errors Skipped Total
MathTest 147 0 2 0 149
MiscTest 178 375 181 137 871
Prod1Test 4832 851 1812 743 8238
Fn1Test 2587 611 1730 367 5295
SerTest 4 2 1 336 343
Fn2Test 2929 958 1489 464 5840
AppTest 970 63 1086 38 2157
Prod2Test 1730 546 1169 524 3969
ArrayTest 0 45 155 9 209
XsTest 89 14 12 49 164
OpTest 4012 117 194 43 4366
MapTest 4 23 193 0 220
Total 17482 3605 8024 2710 31821
RumbleDB, JSONiq parser
Test Suite Passing Failing Errors Skipped Total
MiscTest 162 284 114 311 871
ArrayTest 0 0 0 209 209
Fn1Test 2400 177 118 2600 5295
XsTest 89 0 0 75 164
Prod1Test 3902 201 324 3811 8238
SerTest 4 0 0 339 343
Fn2Test 2659 288 85 2808 5840
MapTest 3 1 14 202 220
AppTest 971 17 20 1149 2157
Prod2Test 1320 221 129 2299 3969
OpTest 3742 28 21 575 4366
MathTest 147 0 1 1 149
Total 15399 1217 826 14379 31821

Download detailed test results

@github-actions
Copy link

github-actions bot commented Nov 20, 2025

Test Results (qt3tests)

RumbleDB, XQuery parser
Test Suite Passing Failing Errors Skipped Total
MathTest 147 0 2 0 149
MiscTest 178 375 181 137 871
Prod1Test 4832 851 1812 743 8238
Fn1Test 2587 611 1730 367 5295
SerTest 4 2 1 336 343
Fn2Test 2929 958 1489 464 5840
AppTest 970 63 1086 38 2157
Prod2Test 1730 546 1169 524 3969
ArrayTest 0 45 155 9 209
XsTest 89 14 12 49 164
OpTest 4011 118 194 43 4366
MapTest 4 23 193 0 220
Total 17481 3606 8024 2710 31821
RumbleDB, JSONiq parser
Test Suite Passing Failing Errors Skipped Total
MiscTest 162 284 114 311 871
ArrayTest 0 0 0 209 209
Fn1Test 2400 177 118 2600 5295
XsTest 89 0 0 75 164
Prod1Test 3902 201 324 3811 8238
SerTest 4 0 0 339 343
Fn2Test 2659 288 85 2808 5840
MapTest 3 1 14 202 220
AppTest 971 17 20 1149 2157
Prod2Test 1320 221 129 2299 3969
OpTest 3742 28 21 575 4366
MathTest 147 0 1 1 149
Total 15399 1217 826 14379 31821

Download detailed test results

@github-actions
Copy link

github-actions bot commented Nov 20, 2025

Test Results (qt3tests)

RumbleDB, XQuery parser
Test Suite Passing Failing Errors Skipped Total
MathTest 147 0 2 0 149
MiscTest 178 375 181 137 871
Prod1Test 4832 851 1812 743 8238
Fn1Test 2587 611 1730 367 5295
SerTest 4 2 1 336 343
Fn2Test 2929 950 1497 464 5840
AppTest 970 63 1086 38 2157
Prod2Test 1730 546 1169 524 3969
ArrayTest 0 45 155 9 209
XsTest 89 14 12 49 164
OpTest 4011 118 194 43 4366
MapTest 4 23 193 0 220
Total 17481 3598 8032 2710 31821
RumbleDB, JSONiq parser
Test Suite Passing Failing Errors Skipped Total
MiscTest 162 284 114 311 871
ArrayTest 0 0 0 209 209
Fn1Test 2400 177 118 2600 5295
XsTest 89 0 0 75 164
Prod1Test 3902 201 324 3811 8238
SerTest 4 0 0 339 343
Fn2Test 2659 282 91 2808 5840
MapTest 3 1 14 202 220
AppTest 971 17 20 1149 2157
Prod2Test 1320 221 129 2299 3969
OpTest 3742 28 21 575 4366
MathTest 147 0 1 1 149
Total 15399 1211 832 14379 31821

Download detailed test results

@ghislainfourny
Copy link
Member Author

ghislainfourny commented Nov 20, 2025

@EPMatt it would be fantastic if you could also throw an eye on these changes to make sure there is no obvious overlook.

EPMatt
EPMatt approved these changes Nov 26, 2025
View reviewed changes
Copy link
Collaborator

@EPMatt EPMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a small question: is commenting output lines like this intentional?

// System.err.println(AnnotationsTestsBase.counter++ + " : " + this.testFile);

If that is intentional, we could remove the lines all together, and also drop the counter property from RumbleDBTestCommons, as it looks like it's not used / updated anywhere else.

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

Test Results (qt3tests)

RumbleDB, XQuery parser
Test Suite Passing Failing Errors Skipped Total
MathTest 147 0 2 0 149
MiscTest 178 375 181 137 871
Prod1Test 4832 851 1812 743 8238
Fn1Test 2587 611 1730 367 5295
SerTest 4 2 1 336 343
Fn2Test 2929 950 1497 464 5840
AppTest 970 63 1086 38 2157
Prod2Test 1730 546 1169 524 3969
ArrayTest 0 45 155 9 209
XsTest 89 14 12 49 164
OpTest 4011 118 194 43 4366
MapTest 4 23 193 0 220
Total 17481 3598 8032 2710 31821
RumbleDB, JSONiq parser
Test Suite Passing Failing Errors Skipped Total
MiscTest 162 284 114 311 871
ArrayTest 0 0 0 209 209
Fn1Test 2400 177 118 2600 5295
XsTest 89 0 0 75 164
Prod1Test 3902 201 324 3811 8238
SerTest 4 0 0 339 343
Fn2Test 2659 282 91 2808 5840
MapTest 3 1 14 202 220
AppTest 971 17 20 1149 2157
Prod2Test 1320 221 129 2299 3969
OpTest 3742 28 21 575 4366
MathTest 147 0 1 1 149
Total 15399 1211 832 14379 31821

Download detailed test results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EPMatt EPMatt EPMatt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ghislainfourny @EPMatt