Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Oct 26, 2022. It is now read-only.

Conversation

@kthare10
Copy link
Contributor

Updated the comments to resolve javadocs error
verified by running the below command. no errors reported
$ mvn -X release:prepare -Prelease -DdryRun=true

@kthare10 kthare10 requested review from ibaldin and mjstealey August 23, 2018 21:40
@mjstealey
Copy link
Member

@kthare10 - with 630+ files changed this is difficult to look at piecemeal...

The dry run is against OSSRH? or just our local artifact repo?

References for OSSRH

@kthare10
Copy link
Contributor Author

@mjstealey - dry run is against local repo. In order to keep OSSRH changes separate and easy for review as it involves renaming the packages too. I was planning to make those changes separately on a branch for #207

Copy link
Member

@mjstealey mjstealey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kthare10 kthare10 merged commit d6b2cb4 into master Aug 27, 2018
@kthare10 kthare10 deleted the 204-javadoc branch August 27, 2018 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants