Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Oct 26, 2022. It is now read-only.

Br231 #233

Merged
merged 2 commits into from
Nov 28, 2018
Merged

Br231 #233

merged 2 commits into from
Nov 28, 2018

Conversation

@kthare10
Copy link
Contributor

Fix for #231

Topology with an unbound VM and stitchport receives exception.

Refer RENCI-NRIG/exogeni#236 for more details

Adding below rule prevents such requests:

 # Stitchport cannot be attached to an unbound VM
 [validateStitchPort2: (?v rb:validation on()) ->
     [ (?Z rb:violation error('Stitchport cannot be attached to an unbound Node', 'Stitchport cannot be attached to an unbound Node', ?X))
         <- (?X req:inDomain http://geni-orca.renci.org/owl/orca.rdf#Stitching/Domain), (?X topo:hasInterface ?I1),
         (?C topo:hasInterface ?I1), (?C rdf:type topo:Link), (?C topo:hasInterface ?I2), (?N topo:hasInterface ?I2), (?N rdf:type comp:ComputeElement),
         noValue(?N req:inDomain ) ] ]

@kthare10 kthare10 self-assigned this Nov 28, 2018
@kthare10 kthare10 requested a review from ibaldin November 28, 2018 17:56
@ibaldin
Copy link
Contributor

ibaldin commented Nov 28, 2018

Approved.

@kthare10 kthare10 merged commit b4f9dbc into master Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ibaldin ibaldin Awaiting requested review from ibaldin

Assignees

@kthare10 kthare10

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kthare10 @ibaldin