Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@tarehart
Copy link
Collaborator

@tarehart tarehart commented Apr 3, 2018

Most of this diff is me moving all the python files into a folder so we can package them into a zip file in a predictable way.

Capabilities:

  • ./gradlew build will do the following:
    • install the python dependencies in requirements.txt
    • take the protobuf python file from our RLBotProtoMaven dependency and put it where runner can see it
    • compile the java framework into a jar
  • ./gradlew publishToMavenLocal will allow us to consume this package from elsewhere via jitpack, and it creates these artifacts:
    • -python.zip: includes all our python files, plus the dlls and injector
    • .jar: bot manager for java bots
    • -sources.jar: source files for the above
    • .pom: maven metadata

This enables us to later make a sample bot repository / zip file which does not include the framework code. The instructions would be something like this:

  • Clone (or just download) our sample bot repository.
  • Double click runner.bat (hypothetical)
    • It executes ./gradlew build
      • causing the framework files to be downloaded
      • and all the python dependencies in the framework's requirements.txt to be installed
    • and then executes python runner_GUI.py to pop open our GUI

Depending on how the build.gradle file is written in the sample bot repository, this could cause the framework to auto-update every time runner.bat is executed.

Copy link
Contributor

@dtracers dtracers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find anything really wrong with this.
Fix the integration test and add comments to the build file

from sourceSets.main.allSource
}

def gitignoreToList(File f) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this used for?

Can we add a comment of it's purpose?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think more generally add comments about what each section independently does.

@tarehart tarehart merged commit 8d88d78 into RLBot:v4 Apr 9, 2018
@tarehart tarehart deleted the gradle-build branch April 9, 2018 05:08
tarehart added a commit that referenced this pull request Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants