-
Notifications
You must be signed in to change notification settings - Fork 119
Setting up gradle building and publishing #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not find anything really wrong with this.
Fix the integration test and add comments to the build file
| from sourceSets.main.allSource | ||
| } | ||
|
|
||
| def gitignoreToList(File f) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this used for?
Can we add a comment of it's purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think more generally add comments about what each section independently does.
Most of this diff is me moving all the python files into a folder so we can package them into a zip file in a predictable way.
Capabilities:
./gradlew buildwill do the following:./gradlew publishToMavenLocalwill allow us to consume this package from elsewhere via jitpack, and it creates these artifacts:This enables us to later make a sample bot repository / zip file which does not include the framework code. The instructions would be something like this:
./gradlew buildpython runner_GUI.pyto pop open our GUIDepending on how the build.gradle file is written in the sample bot repository, this could cause the framework to auto-update every time runner.bat is executed.