Make c++17 standard, update MIOpen for the new CK API#1761
Make c++17 standard, update MIOpen for the new CK API#1761JehandadKhan merged 12 commits intodevelopfrom
Conversation
| template <typename T> | ||
| struct tensor_reorder_driver : tensor_reorder_base_driver | ||
| { | ||
| // NOLINTBEGIN(clang-analyzer-cplusplus.NewDeleteLeaks) |
There was a problem hiding this comment.
@atamazov clang-tidy insists there is a memory leak on Line 452. Could you help to take a look?
| -Wno-unused-command-line-argument | ||
| -Wno-weak-vtables | ||
| -Wno-covered-switch-default | ||
| -Wno-unused-result |
There was a problem hiding this comment.
Why are we disabling this warning? This is a useful warning.
There was a problem hiding this comment.
Because its beyond the scope of this PR. This PR focuses on enabling CK in MIOpen. We plan to properly fix these warnings in subsequent PRs
There was a problem hiding this comment.
This PR focuses on enabling CK in MIOpen.
Regardless of the task needed, the warnings should be required to be fixed(or suppressed locally with pragmas) for all PRs.
We plan to properly fix these warnings in subsequent PRs
If its not being fixed when driven by features/defect then it will less likely be fixed by aesthetics.
Also, CK should wait until MIOpen has C++17 fully enabled before updating their headers to use C++17.
| -modernize-use-nodiscard | ||
| -modernize-concat-nested-namespaces | ||
| -modernize-unary-static-assert |
There was a problem hiding this comment.
Should I take care about these?
| #CPP-17 and ROCM 5.3 update related warning | ||
| -misc-confusable-identifiers | ||
| -modernize-use-nodiscard | ||
| -modernize-concat-nested-namespaces | ||
| -modernize-unary-static-assert | ||
| -modernize-macro-to-enum | ||
| -readability-simplify-boolean-expr | ||
| -readability-redundant-declaration | ||
| -hicpp-member-init | ||
| -bugprone-use-after-move | ||
| -hicpp-invalid-access-moved |
| -Wno-unused-command-line-argument | ||
| -Wno-weak-vtables | ||
| -Wno-covered-switch-default | ||
| -Wno-unused-result |
Uh oh!
There was an error while loading. Please reload this page.