Fix GTest skip/fail propagation throughout bitwise repro tests #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…func GTEST_SKIP and GTEST_FAIL return from the current function, but if we're not in the top-level function called by gtest, the test will continue. Instead, throw a specific exception for each case and catch it at the top level. * params_gen: move to shared
Works around a problem on very old (v7) C++ headers.
|
Performance reports: |
af-ayala
approved these changes
Jul 10, 2024
feizheng10
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.2 cherry pick for https://ontrack-internal.amd.com/browse/SWDEV-465970.
Cherry picked commits: a241030, e823105, and c74e60d.