feat: add version list to rocm-ds flavor & improve header version & fix header banner display error #1442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR for changing latest_versions.txt: #1191 |
neon60
approved these changes
Oct 23, 2025
|
Code looks good, I did not test locally. |
|
The unit tests are failing do we know, why? |
This PR requires #1191 to be merged together. Without #1191, the build won't pass. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
More components are added other than main ROCm components. They need a place to define latest version so that "latest" version on RTD can extract the latest version for the header and header banner can be triggered properly.
Technical Details
Modifies the latest_versions.txt format to include the latest version for each flavor. Note, key name has to match flavor name.
Each jinja header now receives a dictionary of latest version {site_name: latest_version} and can extract its own version accordingly. This PR also modifies project.py to properly utilize the latest version to update
app.config.projects_version_type. This variable is a criteria for header banner display, this will fix the header banner display error for non-rocm component.Test Plan
Build non-rocm docs locally to see if header banner displays properly and if header version is correct for latest.
Test Result
Submission Checklist