CI: push docker image with perf-maxtext tag #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleshofer
requested changes
Jun 30, 2025
15c2d8c to
9caf1e9
Compare
charleshofer
reviewed
Jul 8, 2025
charleshofer
approved these changes
Jul 14, 2025
Collaborator
charleshofer
left a comment
There was a problem hiding this comment.
Looks good. Not a huge deal if we fix the branch name before merging. Depends on what we can do with the maxtext repo.
| RUN apt-get update && apt-get install -y git | ||
|
|
||
| # Clone MaxText from rv_jax branch. | ||
| ARG MAXTEXT_BRANCH=rv_jax |
Collaborator
There was a problem hiding this comment.
Minor, but I think this would be better to set in the workflow file so that we can just look at the workflow file to tell where maxtext is pulled from. Could we name this just jax, instead of having your initials in there, too 😛
Contributor
Author
There was a problem hiding this comment.
ok yes, I need to change the jax branch in the maxtext repo. Maybe change it to jax_perf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfile.maxtextto extend the existingjax-ubu22base image with MaxText source and dependencies.jax-ubu22.rocm<version>)nightlyfor latest builds<commit_sha>for traceabilityrun<github.run_id>for one-to-one mapping with workflow runsrun<run_id>tag.This enables consistent nightly builds and version tracking for MaxText performance evaluation runs.