Adding namespace patch for correctly finding kernels if ROCm 7 is used #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
fixing the path and dynamically finding the path in a second commit... |
Ruturaj4
requested changes
Jul 2, 2025
…ion is found (made it dynamic)
Ruturaj4
requested changes
Jul 2, 2025
mrodden
approved these changes
Jul 7, 2025
| major_version=$(echo "$ROCM_VERSION" | cut -d. -f1) && \ | ||
| if [ "$major_version" -ge 7 ]; then \ | ||
| echo "Applying patch for ROCm $ROCM_VERSION..."; \ | ||
| dist_packages=$(python3 -c "import sysconfig; print(sysconfig.get_paths()['purelib'])") && \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for patching the installed jaxlib from dist_packages to correctly find the kernels if ROCm 7 is used. It is necessary to be able to fix many unit tests (which especially use the hipsolver kernels).
The patch is currently located in the third_party directory, but may be moved in the future. If it is moved, don't forget to modify the Dockerfile patch mount paths.