Fixed test runners #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hon version of run_multi_gpu.sh, except this works, run_multi_gpu.sh halts in the middle
psanal35
reviewed
Aug 16, 2025
psanal35
approved these changes
Aug 17, 2025
Contributor
psanal35
left a comment
There was a problem hiding this comment.
LGTM --good bash-to-Python migration with improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixed run_single_gpu bug and adding run_multi_gpu.py which is the python version of run_multi_gpu.sh, except this works, run_multi_gpu.sh halts in the middle
Technical Details
Added test name normalization to run_single_gpu, which allows finding multi-gpu tests from config correctly and excluding them, since they run in run_multi_gpu script
Added run_multi_gpu.py script as run_multi_gpu.sh bash script halts in the middle, which causes incomplete test run. Python version works fine.
Test Plan
Executed the whole test suite (run_single_gpu.py and run_multi_gpu.py) and collected results.
Test Result
We have 0 failed tests in the latest build of ROCm. Both the single-GPU and multi-GPU tests are fully executed and a final_compiled_report is created for all the tests successfully.
Submission Checklist
Checked formatting with pylint and black.