Update build scripts for new plugin layout #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the build scripts to support the new plugin layout and streamline ROCm installation and CI processes.
- Removes deprecated workflow README.
- Introduces a new tool (get_rocm.py) for ROCm version management and package installation.
- Adds a CI build script (ci_build) for building wheels, docker images, and running tests.
Reviewed Changes
Copilot reviewed 35 out of 52 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| jax_rocm_plugin/.github/workflows/README.md | Removed outdated GitHub Actions workflow documentation. |
| build/tools/get_rocm.py | New script to manage ROCm installation and system-specific packages. |
| build/ci_build | New CI build script supporting wheel distribution and docker build/test. |
Files not reviewed (17)
- .dockerignore: Language not supported
- build/ci.sh: Language not supported
- build/requirements.txt: Language not supported
- docker/Dockerfile.jax-ubu22: Language not supported
- docker/Dockerfile.jax-ubu24: Language not supported
- docker/Makefile: Language not supported
- jax_rocm_plugin/.github/workflows/asan.yaml: Language not supported
- jax_rocm_plugin/.github/workflows/bazel_cpu_rbe.yml: Language not supported
- jax_rocm_plugin/.github/workflows/bazel_gpu_rbe.yml: Language not supported
- jax_rocm_plugin/.github/workflows/build_artifacts.yml: Language not supported
- jax_rocm_plugin/.github/workflows/ci-build.yaml: Language not supported
- jax_rocm_plugin/.github/workflows/cloud-tpu-ci-nightly.yml: Language not supported
- jax_rocm_plugin/.github/workflows/cloud-tpu-ci-presubmit.yml: Language not supported
- jax_rocm_plugin/.github/workflows/jax-array-api.yml: Language not supported
- jax_rocm_plugin/.github/workflows/metal_plugin_ci.yml: Language not supported
- jax_rocm_plugin/.github/workflows/pytest_cpu.yml: Language not supported
- jax_rocm_plugin/.github/workflows/pytest_cuda.yml: Language not supported
Comments suppressed due to low confidence (2)
build/ci_build:64
- The variable LOG is used here but not defined. Please define a logger (e.g., using logging.getLogger(name)) or replace its usage with another logging mechanism.
LOG.warning("Exception while retrieving xla_commit: %s" % ex)
build/ci_build:265
- The function 'build_test_docker' is invoked but not defined or imported. Please ensure that this function is properly defined to avoid runtime errors.
build_test_docker(
Collaborator
charleshofer
left a comment
There was a problem hiding this comment.
It's fine with me if you leave all of that CI stuff in there, but we don't need like 75% of it. I can just go through and remove unused stuff in another PR though.
Collaborator
|
Disregard my comment on the CI stuff. Deleting it all is the right thing. I misread the PR and thought it was an add. |
gulsumgudukbay
requested changes
May 7, 2025
Contributor
gulsumgudukbay
left a comment
There was a problem hiding this comment.
Have a comment on the jax_rocm_plugin/build/rocm/tools/build_wheels.py script
charleshofer
approved these changes
May 7, 2025
Adds a build/ci.sh script as an example of how to run the plugin build, docker image build, and run some tests in the built docker image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.