I tested both cases locally,

Additionally, the pytest command should be modified to reflect the continue_on_fail logic.

Thank you for catching this, I did not realized pytest has its own flag. In this case, we can remove break in the loop?

Additionally, the pytest command should be modified to reflect the continue_on_fail logic.

Thank you for catching this, I did not realized pytest has its own flag. In this case, we can remove break in the loop?

Depends. So the loop traverses the test files. pytest's -x flag stops the test file execution if any unit test within a file fails. However the loop traverses the files and it stops **traversing the files ** after any test within a file fails.
So the -x argument is for within the file, however your break statement is for the whole loop that traverses the files.

Depending on the use case, if you want the loop to halt, you can keep the break statement. If you do not want the loop to halt but you want the test file execution to halt, you can remove the break statement.

Additionally, the pytest command should be modified to reflect the continue_on_fail logic.

Thank you for catching this, I did not realized pytest has its own flag. In this case, we can remove break in the loop?

Depends. So the loop traverses the test files. pytest's -x flag stops the test file execution if any unit test within a file fails. However the loop traverses the files and it stops **traversing the files ** after any test within a file fails. So the -x argument is for within the file, however your break statement is for the whole loop that traverses the files.

Depending on the use case, if you want the loop to halt, you can keep the break statement. If you do not want the loop to halt but you want the test file execution to halt, you can remove the break statement.

I tested this and break seems redundant as it stands, but I am leaving it -- in any case it is correct to keep it~