Add /opt/rocm/lib to RPATH so missing ROCm libs are found #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gulsumgudukbay
requested changes
Oct 16, 2025
Contributor
gulsumgudukbay
left a comment
There was a problem hiding this comment.
Could you please add how you tested this? Do the tests work now?
Contributor
Author
Yes, I can start the nightly wheel builds to make sure the issue is gone. |
gulsumgudukbay
requested changes
Oct 16, 2025
Co-authored-by: Gulsum Gudukbay Akbulut <[email protected]>
f3b635d to
76dc99e
Compare
Contributor
Author
|
These wheels generated in: https://github.com/ROCm/rocm-jax/actions/runs/18574505896, will be tested. |
gulsumgudukbay
requested changes
Oct 16, 2025
Contributor
Author
|
Started another nightly: https://github.com/ROCm/rocm-jax/actions/runs/18576729511, cancelled the previous one. |
gulsumgudukbay
approved these changes
Oct 28, 2025
Contributor
Author
|
I previously hit the same issue on this branch, in a .venv and with prebuilt wheels. I have not been able to re-run tests yet, but the earlier JAX 0.6.0 PR and prior experience, this should address the problem. I 'll follow up with a verification run when I have cycles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR #135
Similarly, the wheels generated in nightly builds had the same issue while running a workload.