Fix rocminfo when run within docker environments. #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, rocminfo will fail when executed inside a docker container due to a missing ROCk module. This has impacts on rocprofiler use. However, a missing ROCk module is expected within a docker environment. Fix this by searching for the "docker" string within the self-cgroups. If it is found, we do not error on a missing ROCk module.
|
All the whitespace patches should be squashed into the original patch. As an alternative idea, instead of looking for amdgpu in lspci, can the container see the directory /sys/module/amdgpu? |
Contributor
Author
|
@fxkamd that directory is visible from within the container environment |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, rocminfo will fail when executed inside a docker container
due to a missing ROCk module. This has impacts on rocprofiler use.
However, a missing ROCk module is expected within a docker environment.
Fix this by searching for the "docker" string within the self-cgroups.
If it is found, we do not error on a missing ROCk module.