Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix rocminfo when run within docker environments. #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
iotamudelta wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix rocminfo when run within docker environments. #49

iotamudelta wants to merge 1 commit into from

Conversation

@iotamudelta
Copy link
Contributor

@iotamudelta iotamudelta commented Nov 8, 2021 •
edited
Loading

Currently, rocminfo will fail when executed inside a docker container
due to being unable to lsmod inside docker. This has impacts on rocprofiler use.

Fix this behavior by querying initstate of the amdgpu module from
/sys/module/amdgpu instead. If initstate is marked "live" everything is
fine - error out with either "not loaded" (initstate file does not
exist) or "not live" (initstate file does not contain "live" string).

@iotamudelta
Fix rocminfo when run within docker environments.
60b191e 
Currently, rocminfo will fail when executed inside a docker container
due to being unable to lsmod inside docker. This has impacts on rocprofiler use.

Fix this behavior by querying initstate of the amdgpu module from
/sys/module/amdgpu instead. If initstate is marked "live" everything if
fine - error out with either "not loaded" (initstate file does not
exist) or "not live" (initstate file does not contain "live" string).
@iotamudelta iotamudelta requested a review from fxkamd November 8, 2021 21:56
@iotamudelta iotamudelta mentioned this pull request Nov 8, 2021
Closed
@iotamudelta iotamudelta requested a review from skeelyamd November 8, 2021 21:57
@Maxzor
Copy link

Maxzor commented Jan 1, 2022 •
edited
Loading

Can someone review this please? LGTM, and the current check is pretty dumb.
This is cumbersome, had to do all kinds of wizardry to bypass that.
You could add checks:

  • that /dev/dri and /dev/kfd are mounted
  • that the current user belongs to render&video groups too to prevent "false positives".
    Meaning, rocminfo succeeds while further programs above in the stack won't work.

dayatsin-amd
dayatsin-amd reviewed Nov 21, 2022
View reviewed changes
Copy link
Contributor

@dayatsin-amd dayatsin-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I will submit the patch from our internal repo

@susman
Copy link

susman commented Oct 30, 2023

Querying /sys/module/amdgpu/initstate isn't a good solution either. It doesn't work on systems with the module built-in.
One suggestion would be to look for 0x1002 in /sys/class/drm/card*/device/vendor

@amd-hsivasun
Copy link

amd-hsivasun commented Aug 11, 2025

Unable to import to rocm-systems due to merge conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dayatsin-amd dayatsin-amd dayatsin-amd left review comments

@fxkamd fxkamd Awaiting requested review from fxkamd

@skeelyamd skeelyamd Awaiting requested review from skeelyamd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iotamudelta @Maxzor @susman @amd-hsivasun @dayatsin-amd