Fix parsing of rocminfo output for ISAs with no features defined #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d66dad0 to
3364193
Compare
dayatsin-amd
approved these changes
Mar 27, 2023
Contributor
dayatsin-amd
left a comment
There was a problem hiding this comment.
lgtm. TY. I will merge it from the internal rocminfo repo
rocm-ci
pushed a commit
that referenced
this pull request
Sep 15, 2023
Patch is an internal port of #59 Change-Id: Iea84f49a60abce73716a7451960c20ee0d2b7bca
|
closing this because I think it was merged @dayatsin-amd @krzysz00 please, correct me if I'm wrong |
Author
|
@dhernandez0 This doesn't seem to have been merged, exactly, but there've been other changes that probably fix the issue motivating this PR |
jayhawk-commits
pushed a commit
to ROCm/rocm-systems
that referenced
this pull request
Aug 11, 2025
Patch is an internal port of ROCm/rocminfo#59 Change-Id: Iea84f49a60abce73716a7451960c20ee0d2b7bca [ROCm/rocminfo commit: 34cc693]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substantially useful to https://github.com/ROCmSoftwarePlatform/llvm-project-private/issues/643