Codestin Search App

r-abishek · 2025-09-03T06:07:31Z

Fixes "Compile Warnings - Azure CI" #590

Contains warning fixes for the HIP Backend build
Adds CHECK_RETURN_STATUS for the various hip API calls

Warning fixes for HIP Backend

Copilot

Pull Request Overview

This PR fixes compile warnings for the HIP backend by adding proper return status checking for HIP API calls. The changes address warning issue #590 by wrapping various HIP API calls with CHECK_RETURN_STATUS macro to ensure return values are properly handled.

Wraps HIP memory operations (hipMemset, hipMemcpy, hipMemsetAsync, hipMemcpyAsync) with CHECK_RETURN_STATUS
Adds return status checking for HIP stream operations (hipStreamSynchronize)
Includes return status checking for HIP device operations (hipInit, hipEventElapsedTime, hipGetDeviceProperties)

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/modules/tensor/rppt_tensor_effects_augmentations.cpp	Added CHECK_RETURN_STATUS for hipMemset and hipStreamSynchronize calls
src/modules/tensor/hip/kernel/to_decibels.cpp	Added CHECK_RETURN_STATUS for hipStreamSynchronize calls
src/modules/tensor/hip/kernel/tensor_sum.cpp	Added CHECK_RETURN_STATUS for hipMemsetAsync and hipStreamSynchronize calls
src/modules/tensor/hip/kernel/tensor_stddev.cpp	Added CHECK_RETURN_STATUS for hipMemsetAsync calls
src/modules/tensor/hip/kernel/tensor_min.cpp	Added CHECK_RETURN_STATUS for hipMemsetAsync and hipStreamSynchronize calls
src/modules/tensor/hip/kernel/tensor_mean.cpp	Added CHECK_RETURN_STATUS for hipMemsetAsync calls
src/modules/tensor/hip/kernel/tensor_max.cpp	Added CHECK_RETURN_STATUS for hipMemsetAsync and hipStreamSynchronize calls
src/modules/tensor/hip/kernel/slice.cpp	Added CHECK_RETURN_STATUS for hipStreamSynchronize call
src/modules/tensor/hip/kernel/resize_mirror_normalize.cpp	Added CHECK_RETURN_STATUS for hipMemsetAsync and hipStreamSynchronize calls
src/modules/tensor/hip/kernel/normalize.cpp	Added CHECK_RETURN_STATUS for hipMemsetAsync and hipStreamSynchronize calls
src/modules/tensor/hip/kernel/noise_gaussian.cpp	Added CHECK_RETURN_STATUS for hipMemcpy call
src/modules/tensor/hip/kernel/erase.cpp	Added CHECK_RETURN_STATUS for hipMemcpyAsync and hipStreamSynchronize calls
src/modules/tensor/hip/kernel/crop_and_patch.cpp	Added CHECK_RETURN_STATUS for hipMemcpyAsync and hipStreamSynchronize calls
src/modules/legacy_dep/hip/kernel/snow.cpp	Added CHECK_RETURN_STATUS for hipMemcpy call
src/modules/handle_hip.cpp	Added CHECK_RETURN_STATUS for hipInit, hipEventElapsedTime, and hipGetDeviceProperties calls
src/include/common/rppi_validate.hpp	Added CHECK_RETURN_STATUS for various hipMemcpy calls

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/modules/tensor/hip/kernel/crop_and_patch.cpp

src/include/common/rppi_validate.hpp

src/modules/legacy_dep/hip/kernel/snow.cpp

rrawther

please address the review comments

codecov · 2025-09-16T23:34:47Z

Codecov Report

❌ Patch coverage is 77.22772% with 23 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/include/common/rppi_validate.hpp	29.41%	12 Missing ⚠️
src/modules/tensor/hip/kernel/normalize.cpp	45.45%	6 Missing ⚠️
src/modules/handle_hip.cpp	33.33%	2 Missing ⚠️
src/modules/legacy_dep/hip/kernel/snow.cpp	0.00%	1 Missing ⚠️
src/modules/tensor/hip/kernel/slice.cpp	0.00%	1 Missing ⚠️
src/modules/tensor/hip/kernel/to_decibels.cpp	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #606      +/-   ##
===========================================
+ Coverage    88.41%   88.44%   +0.04%     
===========================================
  Files          196      195       -1     
  Lines        82769    82768       -1     
===========================================
+ Hits         73173    73203      +30     
+ Misses        9596     9565      -31

Files with missing lines	Coverage Δ
src/modules/tensor/hip/kernel/crop_and_patch.cpp	`99.17% <100.00%> (ø)`
src/modules/tensor/hip/kernel/erase.cpp	`99.33% <100.00%> (ø)`
src/modules/tensor/hip/kernel/noise_gaussian.cpp	`84.80% <100.00%> (ø)`
...ules/tensor/hip/kernel/resize_mirror_normalize.cpp	`100.00% <100.00%> (ø)`
src/modules/tensor/hip/kernel/tensor_max.cpp	`98.88% <100.00%> (ø)`
src/modules/tensor/hip/kernel/tensor_mean.cpp	`98.84% <100.00%> (ø)`
src/modules/tensor/hip/kernel/tensor_min.cpp	`98.88% <100.00%> (ø)`
src/modules/tensor/hip/kernel/tensor_stddev.cpp	`98.88% <100.00%> (ø)`
src/modules/tensor/hip/kernel/tensor_sum.cpp	`98.84% <100.00%> (ø)`
...dules/tensor/rppt_tensor_effects_augmentations.cpp	`95.93% <100.00%> (ø)`
... and 6 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull Request Overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot

Pull Request Overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

rrawther · 2025-09-23T15:37:15Z

src/modules/tensor/hip/kernel/tensor_sum.cpp

@@ -1212,7 +1212,7 @@ RppStatus hip_exec_tensor_sum(T *srcPtr,
        Rpp32u partialSumArrLength = gridDim_x * gridDim_y * gridDim_z;
        float *partialSumArr;
        partialSumArr = handle.GetInitHandle()->mem.mgpu.scratchBufferHip.floatmem;


partialSumArr gets allocated in scratch_mem without even checking if there is enough memory available. This is very dangerous and can cause mem allocation failures. We need to get rid of this kind of memory allocation. We would like to catch failure on allocation and gracefully exit if it happens instead of not assuming any bounds for memory

rrawther

Added a comment regarding the use of scratch memory. Need to have a better mechanism

kiritigowda · 2025-09-23T23:33:20Z

All warnings fixed on AzureCI

[167/175] Building CXX object src/modules/CMakeFiles/modules.dir/tensor/cpu/kernel/water.cpp.o
[168/175] Building CXX object src/modules/CMakeFiles/modules.dir/legacy_dep/hip/kernel/fisheye.cpp.o
[169/175] Building CXX object src/modules/CMakeFiles/modules.dir/legacy_dep/hip/kernel/hue_saturation.cpp.o
[170/175] Building CXX object src/modules/CMakeFiles/modules.dir/legacy_dep/hip/kernel/snow.cpp.o
[171/175] Building CXX object src/modules/CMakeFiles/modules.dir/legacy_dep/cpu/kernel/fisheye.cpp.o
[172/175] Building CXX object src/modules/CMakeFiles/modules.dir/legacy_dep/cpu/kernel/hue_saturation.cpp.o
[173/175] Building CXX object src/modules/CMakeFiles/modules.dir/legacy_dep/cpu/kernel/snow.cpp.o
[174/175] Linking CXX shared library lib/librpp.so.2.1.0
[175/175] Creating library symlink lib/librpp.so.2 lib/librpp.so

Copilot

Pull Request Overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

* Initial hip memory fixes * Further hip warning fixes * Default build warning fixes - group III --------- Co-authored-by: Srihari-mcw <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]>

* Box filter - padding updates (#597) * Updates for box filter to test * Box Filter Newer Commit with fixes * Further updates to match PKD3 and PLN3 output * Fixes for RPP Box filter border replicate - Fix accuracy * Rename variables * Restore AVX and Update AVX code for box filter * Box Filter float updates * Updates to float version * Compilation fixes * HIP Updates for Box Filter kernelSize = 3 * HIP Updates for PLN Code * HIP Updates for kernelSize = 5 * HIP Updates for kernelSize = 7 * HIP Updates for kernelSize = 9 * Remove additional else * Fix issues with alignedLength for kernelSize 3 float variants PKD3 to PLN3 * Add golden outputs * Add additional borderType parameter * Separate float implementation for 3x3 box filter planar * Rename function * Introduce functions to calculate in float type itself * Updates for PKD variants * Compilation fixes * Updates for PKD3 to PLN3 * Fix accuracy issues * PLN3 to PKD3 updates for box filter * Float shared variables * Overload box filter for various kernelSizes * Template the PKD3 and PLN3 implementations * Template the rest of the implementations * Initial cleanup of HIP Code * Cleanup of code with parameter passing launch of kernel * Add further comments * Add more comments and minor cleanups further * Initial cleanup of cpu kernel code * Add comments for padding * Add reference outputs in docs/data/doxygenOutputs * Update documentation * Minor corrections * Updates to move filter structure as common code * Update the separation based on type * Update rpp_hip_load_store.hpp * Updates for separating i8 for PLN3 code * Fixes for PLN3 and further updates for kernelSize = 3 * I8 updates for kernelSize = 5 * Updates for kernelSize = 7 * Updates for kernelSize = 9 * Fixes for kernelSize = 9 * Remove saturate pixel * Rename function * Update comment * Add declarations for I8 functions with rounding * Whitespace and type updates * Updates for performance - U8/I8 * Templated the box filter compute functions for all kernel sizes and optimized the I8 variants * Update comments * Make initial changes to template unpack function * Fixes for box filter compilation * modified padding load logic * Update the round function used * Rename verticalDirection and horizontalDirection to padVertical and padHorizontal * Fix accuracy issues --------- Co-authored-by: Abishek <[email protected]> Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: Lakshmi Kumar <[email protected]> * Docs - removing SP6 (#609) Co-authored-by: Kiriti Gowda <[email protected]> * Packaging - Remove Meta Package dependency (#610) Co-authored-by: Kiriti Gowda <[email protected]> * Bugfix - Handle (#600) * Fix handle mem leaks * Add variable to capture rpp::try_ return status * Add handle deletes inside lambda function * modified handle delete --------- Co-authored-by: Maddisetty <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: HazarathKumarM <[email protected]> * Docs - Updated doxyfile with correct api input path (#614) Co-authored-by: Kiriti Gowda <[email protected]> * Test Package - Add cmake deps (#617) * Solarize augmentation - HOST and HIP (#605) * Solarize HIP and HOST implementation * cleanup the code and fix pkd3-pkd3 performance * Add golden output and doxygen comments * Add cheks for Threshold param * modified case num for solarize * minor fix * fix load/store calls * Address review comments * minor fix --------- Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Maddisetty <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * Docs - Bump rocm-docs-core[api_reference] from 1.23.0 to 1.24.1 in /docs/sphinx (#620) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.23.0 to 1.24.1. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.24.1/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.23.0...v1.24.1) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.24.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Warning fixes for HIP Backend - Check return status (#606) * Initial hip memory fixes * Further hip warning fixes * Default build warning fixes - group III --------- Co-authored-by: Srihari-mcw <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (#623) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.26.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ROCm 7.1 - Changelog updates (#625) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Srihari-mcw <[email protected]> Co-authored-by: Abishek <[email protected]> Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Lakshmi Kumar <[email protected]> Co-authored-by: spolifroni-amd <[email protected]> Co-authored-by: arvindcheru <[email protected]> Co-authored-by: Maddisetty <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Srihari-mcw <[email protected]>

* Initial hip memory fixes * Further hip warning fixes * Default build warning fixes - group III --------- Co-authored-by: Srihari-mcw <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]>

* Optimized version of channel dropout HIP backend and working code for HOST AVX, SSE * Modified name for dropout compute function * Modified way of AVX and SSE version channel dropout to avoid if statments * Modified Channel Dropout with generic compute code reused * Parameters and name change for channel dropout * Modified HIP for better performance * Modified the code and made the channel dropout templated version for all the bitdepths * Added output image and modified the .h file to effects for channel dropout * added space * Resolved all review comments and modified code to produce results for i8 variant * Removed empty line * Resolved review comments * Modified HOST after merge * Made changes after merging and QA passed for dropout * Channel dropout make_float 4 macro changes * Updated QA with random generator and updated BIN files * Modified QA name changes * Modified RandomSeed value passed as parameter to the function call * Update rppt_tensor_effects_augmentations.cpp indentation modified * Removed space and review comments resolved * channel dropout implementation * Resolved all the review comments and modified the magic number to set as constant for better understanding, added required comments * Merged branch from develop and resolved merge conflicts * Removed empty space * Updated omp loop for better performance * Updated hip channel dropout code for PKD version * Updated change after merge * Packaging - Remove Meta Package dependency (#610) Co-authored-by: Kiriti Gowda <[email protected]> * Test Package - Add cmake deps (#617) * Solarize augmentation - HOST and HIP (#605) * Solarize HIP and HOST implementation * cleanup the code and fix pkd3-pkd3 performance * Add golden output and doxygen comments * Add cheks for Threshold param * modified case num for solarize * minor fix * fix load/store calls * Address review comments * minor fix --------- Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Maddisetty <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Warning fixes for HIP Backend - Check return status (#606) * Initial hip memory fixes * Further hip warning fixes * Default build warning fixes - group III --------- Co-authored-by: Srihari-mcw <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (#623) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.26.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ROCm 7.1 - Changelog updates (#625) * HIP - Remove unnecessary int load/stores (#621) * Initial changes for tensor sum for PLN1 and PKD3 variants U8 * Make changes for rest of the bit depths and layouts * Remove unused pack functions * Adjust comments * Initial cleanup * Further cleanup * Remove unused functions * Address copilot comments * Further standardize comments * Standardize comments spacing in functions affected --------- Co-authored-by: Srihari-mcw <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * CXX Compiler - Support TheRock (#630) * Test Suite - Enums for bit depth, output format and layout (#608) * removed numbers for bitdepths and output toggle * Add layout enum and replicate changes to HOST testsuite * Fix copilot review comments * resolve review comments * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> * minor bugfix * minor bugfix * minor fix --------- Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * Docs - Bump rocm-docs-core[api_reference] from 1.26.0 to 1.27.0 in /docs/sphinx (#632) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.26.0 to 1.27.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.26.0...v1.27.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.27.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Packaging - Remove Meta Package dependency (#610) Co-authored-by: Kiriti Gowda <[email protected]> * Test Package - Add cmake deps (#617) * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (#623) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.26.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * HIP - Remove unnecessary int load/stores (#621) * Initial changes for tensor sum for PLN1 and PKD3 variants U8 * Make changes for rest of the bit depths and layouts * Remove unused pack functions * Adjust comments * Initial cleanup * Further cleanup * Remove unused functions * Address copilot comments * Further standardize comments * Standardize comments spacing in functions affected --------- Co-authored-by: Srihari-mcw <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * CXX Compiler - Support TheRock (#630) * Test Suite - Enums for bit depth, output format and layout (#608) * removed numbers for bitdepths and output toggle * Add layout enum and replicate changes to HOST testsuite * Fix copilot review comments * resolve review comments * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> * minor bugfix * minor bugfix * minor fix --------- Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * Docs - Bump rocm-docs-core[api_reference] from 1.26.0 to 1.27.0 in /docs/sphinx (#632) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.26.0 to 1.27.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.26.0...v1.27.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.27.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Modified enum changed for the test suite for dropout * Updated enum changes for dropout * Update utilities/test_suite/HOST/runImageTests.py Co-authored-by: Copilot <[email protected]> * Update utilities/test_suite/HIP/runImageTests.py Co-authored-by: Copilot <[email protected]> * Update utilities/test_suite/HOST/runImageTests.py Co-authored-by: Copilot <[email protected]> * Update utilities/test_suite/HIP/runImageTests.py Co-authored-by: Copilot <[email protected]> * Update utilities/test_suite/HOST/Tensor_image_host.cpp Co-authored-by: Copilot <[email protected]> * Update src/modules/tensor/rppt_tensor_effects_augmentations.cpp Co-authored-by: Copilot <[email protected]> * Update src/modules/tensor/rppt_tensor_effects_augmentations.cpp Co-authored-by: Copilot <[email protected]> * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ROCm 7.1 - Changelog updates (#625) * Resolved copilot review comments for channel dropout * Reverted back the dropoutTypeCases * Updated and resolved reivew comments * Modified common.py file for channel dropout * Reverted changes * Updated common.py changes * updated channel dropout and resolved review comments * Updated random mask in API level * Updated seed to be passed from test suite * Updated Random generator in test suite level * updated name for every instances * Resolved review comments * Resolved Review comments and modified HIP code * Updated and resolved review comments * Modified datatype for channel dropout Hip backend --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: sampath117 <[email protected]> Co-authored-by: RooseweltMcW <[email protected]> Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: arvindcheru <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: Maddisetty <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Srihari-mcw <[email protected]> Co-authored-by: Copilot <[email protected]>

* Optimized version of channel dropout HIP backend and working code for HOST AVX, SSE * Modified name for dropout compute function * Modified way of AVX and SSE version channel dropout to avoid if statments * Modified Channel Dropout with generic compute code reused * Parameters and name change for channel dropout * Modified HIP for better performance * Modified the code and made the channel dropout templated version for all the bitdepths * Added output image and modified the .h file to effects for channel dropout * added space * Resolved all review comments and modified code to produce results for i8 variant * Removed empty line * Resolved review comments * Modified HOST after merge * Made changes after merging and QA passed for dropout * Channel dropout make_float 4 macro changes * Updated QA with random generator and updated BIN files * Modified QA name changes * Modified RandomSeed value passed as parameter to the function call * Update rppt_tensor_effects_augmentations.cpp indentation modified * Removed space and review comments resolved * channel dropout implementation * Resolved all the review comments and modified the magic number to set as constant for better understanding, added required comments * Merged branch from develop and resolved merge conflicts * Removed empty space * Updated omp loop for better performance * Updated hip channel dropout code for PKD version * Updated change after merge * Packaging - Remove Meta Package dependency (ROCm#610) Co-authored-by: Kiriti Gowda <[email protected]> * Test Package - Add cmake deps (ROCm#617) * Solarize augmentation - HOST and HIP (ROCm#605) * Solarize HIP and HOST implementation * cleanup the code and fix pkd3-pkd3 performance * Add golden output and doxygen comments * Add cheks for Threshold param * modified case num for solarize * minor fix * fix load/store calls * Address review comments * minor fix --------- Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Maddisetty <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (ROCm#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Warning fixes for HIP Backend - Check return status (ROCm#606) * Initial hip memory fixes * Further hip warning fixes * Default build warning fixes - group III --------- Co-authored-by: Srihari-mcw <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (ROCm#623) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.26.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ROCm 7.1 - Changelog updates (ROCm#625) * HIP - Remove unnecessary int load/stores (ROCm#621) * Initial changes for tensor sum for PLN1 and PKD3 variants U8 * Make changes for rest of the bit depths and layouts * Remove unused pack functions * Adjust comments * Initial cleanup * Further cleanup * Remove unused functions * Address copilot comments * Further standardize comments * Standardize comments spacing in functions affected --------- Co-authored-by: Srihari-mcw <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * CXX Compiler - Support TheRock (ROCm#630) * Test Suite - Enums for bit depth, output format and layout (ROCm#608) * removed numbers for bitdepths and output toggle * Add layout enum and replicate changes to HOST testsuite * Fix copilot review comments * resolve review comments * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> * minor bugfix * minor bugfix * minor fix --------- Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * Docs - Bump rocm-docs-core[api_reference] from 1.26.0 to 1.27.0 in /docs/sphinx (ROCm#632) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.26.0 to 1.27.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.26.0...v1.27.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.27.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Packaging - Remove Meta Package dependency (ROCm#610) Co-authored-by: Kiriti Gowda <[email protected]> * Test Package - Add cmake deps (ROCm#617) * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (ROCm#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (ROCm#623) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.26.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * HIP - Remove unnecessary int load/stores (ROCm#621) * Initial changes for tensor sum for PLN1 and PKD3 variants U8 * Make changes for rest of the bit depths and layouts * Remove unused pack functions * Adjust comments * Initial cleanup * Further cleanup * Remove unused functions * Address copilot comments * Further standardize comments * Standardize comments spacing in functions affected --------- Co-authored-by: Srihari-mcw <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * CXX Compiler - Support TheRock (ROCm#630) * Test Suite - Enums for bit depth, output format and layout (ROCm#608) * removed numbers for bitdepths and output toggle * Add layout enum and replicate changes to HOST testsuite * Fix copilot review comments * resolve review comments * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> * minor bugfix * minor bugfix * minor fix --------- Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * Docs - Bump rocm-docs-core[api_reference] from 1.26.0 to 1.27.0 in /docs/sphinx (ROCm#632) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.26.0 to 1.27.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.26.0...v1.27.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.27.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Modified enum changed for the test suite for dropout * Updated enum changes for dropout * Update utilities/test_suite/HOST/runImageTests.py Co-authored-by: Copilot <[email protected]> * Update utilities/test_suite/HIP/runImageTests.py Co-authored-by: Copilot <[email protected]> * Update utilities/test_suite/HOST/runImageTests.py Co-authored-by: Copilot <[email protected]> * Update utilities/test_suite/HIP/runImageTests.py Co-authored-by: Copilot <[email protected]> * Update utilities/test_suite/HOST/Tensor_image_host.cpp Co-authored-by: Copilot <[email protected]> * Update src/modules/tensor/rppt_tensor_effects_augmentations.cpp Co-authored-by: Copilot <[email protected]> * Update src/modules/tensor/rppt_tensor_effects_augmentations.cpp Co-authored-by: Copilot <[email protected]> * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (ROCm#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ROCm 7.1 - Changelog updates (ROCm#625) * Resolved copilot review comments for channel dropout * Reverted back the dropoutTypeCases * Updated and resolved reivew comments * Modified common.py file for channel dropout * Reverted changes * Updated common.py changes * updated channel dropout and resolved review comments * Updated random mask in API level * Updated seed to be passed from test suite * Updated Random generator in test suite level * updated name for every instances * Resolved review comments * Resolved Review comments and modified HIP code * Updated and resolved review comments * Modified datatype for channel dropout Hip backend --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: sampath117 <[email protected]> Co-authored-by: RooseweltMcW <[email protected]> Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: arvindcheru <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: Maddisetty <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Srihari-mcw <[email protected]> Co-authored-by: Copilot <[email protected]>

Srihari-mcw and others added 4 commits August 28, 2025 13:07

Initial hip memory fixes

9458c75

Further hip warning fixes

6e76a85

Default build warning fixes - group III

f2ed36f

Merge pull request #484 from Srihari-mcw/warning_fixes_hip

6be2348

Warning fixes for HIP Backend

r-abishek requested a review from Copilot September 3, 2025 06:07

r-abishek added the ci:precheckin label Sep 3, 2025

Copilot AI reviewed Sep 3, 2025

View reviewed changes

kiritigowda self-assigned this Sep 4, 2025

kiritigowda requested review from kiritigowda and rrawther September 4, 2025 18:38

rrawther reviewed Sep 12, 2025

View reviewed changes

src/modules/tensor/hip/kernel/crop_and_patch.cpp Show resolved Hide resolved

rrawther reviewed Sep 12, 2025

View reviewed changes

src/include/common/rppi_validate.hpp Show resolved Hide resolved

rrawther reviewed Sep 12, 2025

View reviewed changes

src/modules/legacy_dep/hip/kernel/snow.cpp Show resolved Hide resolved

rrawther requested changes Sep 12, 2025

View reviewed changes

r-abishek mentioned this pull request Sep 16, 2025

[Issue]: Compile Warnings - Azure CI #590

Closed

Merge branch 'develop' into ar/build_fix_hip_warnings

2b8e7db

kiritigowda added 4 commits September 16, 2025 16:51

Merge branch 'develop' into ar/build_fix_hip_warnings

3bcc2bd

Merge branch 'develop' into ar/build_fix_hip_warnings

42b8318

Merge branch 'develop' into ar/build_fix_hip_warnings

e8efdc3

Merge branch 'develop' into ar/build_fix_hip_warnings

1f6e3c8

kiritigowda requested review from Copilot and rrawther September 18, 2025 03:13

Copilot AI reviewed Sep 18, 2025

View reviewed changes

kiritigowda added 2 commits September 22, 2025 10:30

Merge branch 'develop' into ar/build_fix_hip_warnings

8225c90

Merge branch 'develop' into ar/build_fix_hip_warnings

74ca46d

kiritigowda requested a review from Copilot September 23, 2025 03:29

kiritigowda added the BugFix label Sep 23, 2025

Copilot AI reviewed Sep 23, 2025

View reviewed changes

rrawther reviewed Sep 23, 2025

View reviewed changes

Merge branch 'develop' into ar/build_fix_hip_warnings

4724298

kiritigowda approved these changes Sep 23, 2025

View reviewed changes

kiritigowda requested review from Copilot and rrawther September 23, 2025 23:33

Copilot AI reviewed Sep 23, 2025

View reviewed changes

kiritigowda added 2 commits September 24, 2025 14:16

Merge branch 'develop' into ar/build_fix_hip_warnings

de33146

Merge branch 'develop' into ar/build_fix_hip_warnings

b7c8fce

rrawther approved these changes Sep 26, 2025

View reviewed changes

kiritigowda merged commit 6f03edd into ROCm:develop Sep 26, 2025
6 of 8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Warning fixes for HIP Backend - Check return status#606

Warning fixes for HIP Backend - Check return status#606
kiritigowda merged 14 commits intoROCm:developfrom
r-abishek:ar/build_fix_hip_warnings

r-abishek commented Sep 3, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rrawther left a comment

Uh oh!

codecov bot commented Sep 16, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

rrawther Sep 23, 2025

Uh oh!

rrawther left a comment

Uh oh!

kiritigowda commented Sep 23, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

r-abishek commented Sep 3, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rrawther left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

rrawther Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

rrawther left a comment

Choose a reason for hiding this comment

Uh oh!

kiritigowda commented Sep 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Sep 16, 2025 •

edited

Loading