Added the ability to add lights to equipment automatically and light up the fire/infernal cape #85
Conversation
Added the fire cape, infernal cape and their max cape variants to the new equipment lighting
|
I've noticed that when a character runs, the animation for the inferno cape (not sure on fire cape haven't tested/verified), the scrolling texture stops scrolling. Are we able to apply an easy fix here for that, or should we open a separate issue for that? |
this is something entirely separate and has nothing to do with this pull request, so should probably be its own separate issue |
| { | ||
| return (r << 16) | (g << 8) | b; | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Also above here, is it worth/easy to add config for other bits of equipment?
The ones that come to mind are
- https://oldschool.runescape.wiki/w/Bug_lantern
- https://oldschool.runescape.wiki/w/Hallowed_focus
- https://oldschool.runescape.wiki/w/Jack_lantern_mask
- https://oldschool.runescape.wiki/w/Skeleton_lantern
- https://oldschool.runescape.wiki/w/Pumpkin_lantern
Maybe even things like the charged dfs
There was a problem hiding this comment.
The more I think about it, the more pieces of equipment I can think of. Makes sense if you want to leave this PR as just infra and then a second one adding all the equipment
There was a problem hiding this comment.
it's generally pretty easy just got to setup the positioning and brightness etc. It works the same as adding lights for objects, npcs etc. just a bit outside of the scope of both the issue and the amount of time I had available to spend on writing this.
…ghts closer to player; use interpolated player orientation; use annoying complicated logic to account for bridges when calculating tile height
|
made some changes so that it works correctly on bridges. also adjusted the lights a little. I like the feature but want to give it some more thorough testing before merging it |
Would you be open to adding the Firemaking cape as well? It serves as an inextinguishable light source. |
Weighing in, i dont think that makes sense personally. Also would be weird that only 1 skillcape has light. However very weak/subtle lights on some equipment like zenytes, bloodfury, salve, skillcape emote animations (Although i dont think that counts as equipment lights), would be great. |
But it's a light source. It literally functions as something that lights up caves: https://oldschool.runescape.wiki/w/Firemaking_cape |
|
I think it would be useful to eventually allow light to be emitted from the local player when they are in certain areas (caves requiring a light source) with a valid light source equipped or in their inventory. in such a case, the firemaking cape would be a good candidate. otherwise, I think it would look a little mismatched as the firemaking cape doesn't visually imply light emission |
Add kandarin headgear to that list too |
Prospector helmet as well ? |
|
It's probably worth reviewing the wieldable items found here for this PR. |
|
I've updated this to work with the new JSON configuration. Feel free to pull in those changes to this PR 🙂 |
|
@RS117 This would be awesome, would this get approved if the merge conflict is fixed? |
Added the ability to add lights to equipment automatically and added the fire cape, infernal cape and their max cape variants to the new equipment lighting
this would close #54
