New brightness config #96
Conversation
|
how about making the in-game brightness slider sync with this value? |
Yeah but i think its better this way as the plugins brightness doesn't work the same way as the in-game brightness does. Like the plugin has darker dungeons for example where in-game brightness never changes depending where you are so its going to be easier to toggle the plugin without needing to re adjust the in-game brightness. Also the in-game brightness still changes the brightness for item icons in inventory. |
| ) | ||
| @ConfigItem( | ||
| keyName = "brightness", | ||
| keyName = "brightness2", |
There was a problem hiding this comment.
Maybe a better name here than brightness2, like detailedBrightness or something of the sort?
There was a problem hiding this comment.
Yeah well i had to change it or otherwise it will override the old brightness setting and you cant convert it anymore. but the brightness2 only shows as the key name and the method to get it is still called brightness so it doesn't matter that much.
|
If this gets approved and added, can I request similar extensions to the saturation and contrast options? |
this adds a Range config to the brightness setting. So people can change the brightness better as theres 49 different values between 1 and 50. It sets the brightness value by dividing the int value with 20 so its between 0.05 and 2.5 and changing it by one changes the brightness by 0.05. Previously the lowest was 0.5 and highest was 1.5 so people can now put it alot lower which can be cool to see the lighting better and higher to see better in caves and stuff. #83
Also it converts the old brightness setting to the new one so the brightness config wont reset after updating. I also tested this alot and it all works fine.