Transform comp_line_directives from an AoS to a SoA #844
+15
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having an object array with many three-element obj-arrays in it, have two int-arrays and a str-array.
This removes one indirection from line number lookup when searching through the array of comp line directives. Also, this should use less memory at compile time.
This rarely matters very much, except for the generated RakuAST source file that is concatenated into the BOOTSTRAP/v6c.nqp file, which has multiple thousand comp_line_directives and compiling the v6c bootstrap used to spend almost 10% of its time inside method linefileof.
A side-effect of this change is that we now store only a string instead of the whole match object for the filename inside the comp line directives array, which I expect only has a very minor impact on anything.
(SoA means Struct of Array and AoS means Array of Struct. Technically, this was an AoA and turned into a different kind of AoA, but the smaller arrays were always constant-length and each slot had a specified meaning, just like members of a struct, so I think it makes sense to call it that)