Add tests for picking ver/api/auth default from META6 #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additional testing is needed for system collapsing and |
ugexe
reviewed
Sep 16, 2022
ugexe
reviewed
Sep 16, 2022
ugexe
reviewed
Sep 16, 2022
| # Remove the previous installation to guarantee no garbage is left behind. | ||
| self.rmsubdir($dest-dir); | ||
|
|
||
| for $?DISTRIBUTION.meta<resources>.grep({ .starts-with($dist ~ '/') && .ends-with('.in') }) -> IO() $tmpl { |
There was a problem hiding this comment.
The exposed public interface is actually $*DISTRIBUTION.I have no idea why I used $?DISTRIBUTION elsewhere... I think originally it was $?DISTRIBUTION but then later I changed it to $*DISTRIBUTION (which still requires setting up a $?DISTRIBUTION)
There was a problem hiding this comment.
Documentation mentions $?DISTRIBUTION, the compiler installs it too. And it's the right name for it. With $*DISTRIBUTION there is a chance to pick up a wrong one from the call stack. Yet, the lexical nature of $?DISTRIBUTION makes it more error-proof.
Contrary, $*DISTRIBUTION is good for the compilation.
Make sure we don't left behind opened in/out/err.
Make sure templates expanded correctly and distribution reported by module has the version we expect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of rakudo/rakudo#5060