RareGameSlim: fix uploading save games when there aren't any on the remote #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emote If there aren't any saves for the game on the cloud, the game's saves list is empty, and the first check failed. As a result the method would erroneously report that there aren't any save games. This caused the upload/download button in the cloud saves dialog and widget would be disabled. Fix it by removing the check and creating a fake save to satisfy `check_savegame_state`
bbbc883 to
e68ff22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there aren't any saves for the game on the cloud, the game's saves list
is empty, and the first check failed. As a result the method would
erroneously report that there aren't any save games. This caused the
upload/download button in the cloud saves dialog and widget would be
disabled.
Fix it by removing the check and creating a fake save to satisfy
check_savegame_state