Various changes #562
Merged
Various changes #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename `save_*` functions to `adjust_` to better reflect their nature. These function set or remove the an option depending on the value, they do not write to the disk.
Signed-off-by: loathingKernel <[email protected]>
Add a secondary label in IndicatorLineEdit to show the information such as game title.
Fetch Steam AppIDs from our own caching mirror
Due to a race-condition with the IndicatorLineEdit threading, "pending" would be written and saved as the value for steam_grade, causing the protondb grade to never be updated.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors various configuration and UI components across the project while integrating new features and build dependencies. Key changes include updating widget and method names for improved clarity, modifying tag and app name handling in library components, and adding “ruff” as a dependency in several CI workflows.
Reviewed Changes
Copilot reviewed 103 out of 103 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rare/components/tabs/settings/compat.py | Replaced DxvkOverlaySettings with DxvkHudSettings and added DxvkNvapiDrsSettings support. |
| rare/components/tabs/library/widgets/init.py | Updated widget filtering and sorting logic using removeprefix and adjusted lambdas. |
| rare/components/tabs/library/integrations/import_group.py | Replaced AppNameCompleter with ColumnCompleter and changed attribute initialization for app names, titles, and install directories. |
| rare/components/tabs/library/head_bar.py | Refactored tag update logic and completer handling. |
| rare/components/tabs/library/details/game.py | Changed config calls from save_option to adjust_option and updated skip_update check. |
| rare/components/tabs/library/details/details.py | Refactored tag addition and update logic, introduced GameTagCheckBox and GameTagAddDialog. |
| rare/components/tabs/library/details/compat.py | Added Steam AppID handling via IndicatorLineEdit and updated widget settings to use new DxvkHudSettings/DxvkNvapiDrsSettings. |
| rare/components/tabs/library/details/cloud_saves.py | Modified UI logic for displaying cloud saves support information. |
| rare/components/tabs/library/details/init.py | Minor updates to event handling and exception management. |
| rare/components/tabs/library/init.py | Removed a redundant connection related to tag list updates. |
| rare/components/tabs/downloads/init.py | Removed unused widget imports. |
| rare/components/dialogs/login/browser_login.py | Ignored standard error output after changes to the QProcess readout. |
| rare/components/dialogs/install_dialog.py | Removed the unused TagCheckBox class. |
| .github/workflows/* | Added “ruff” as an additional dependency in multiple CI workflows. |
Comments suppressed due to low confidence (2)
rare/components/tabs/library/integrations/import_group.py:155
- Initializing __app_names, __app_titles, and __install_dirs to None may lead to runtime errors if they are accessed before being set in showEvent. Consider initializing them to empty dictionaries/sets (e.g., {} or set()) to ensure safe access.
self.__app_names: Dict[str, str] = None
rare/components/tabs/library/details/game.py:283
- [nitpick] Using a one-line conditional expression with side effects for tag addition/removal can reduce readability and may raise an error if trying to remove a tag that isn’t present. Consider refactoring this into an explicit if-else block with appropriate error handling.
tags.add(tag) if state == Qt.CheckState.Checked else tags.remove(tag)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DXVK_NVAPI_DRS_SETTINGSconfiguratorwidgets/indicator_edit.pyruff checkpendingas a value for steam_grade