chore: remove version_scheme from pyproject.toml
#596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `pip install .` or `python -m build` fails if this directive it present. Both of these commands work correctly without the directive by using a barebones `setup.py`. On the other hand, removing this directive breaks `python3 -m setuptools_scm --force-write-version-files` which is used in the workflows to generate `rare/_version.py` before packaging. In the case of the workflows though we already override the version using `SETUPTOOLS_SCM_PRETEND_VERSION` so it shouldn't be an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
pip install .orpython -m buildfails if this directive itpresent. Both of these commands work correctly without the directive by
using a barebones
setup.py.On the other hand, removing this directive breaks
python3 -m setuptools_scm --force-write-version-fileswhich is usedin the workflows to generate
rare/_version.pybefore packaging. In thecase of the workflows though we already override the version using
SETUPTOOLS_SCM_PRETEND_VERSIONso it shouldn't be an issue.