Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@loathingKernel
Copy link
Contributor

  • Make launch and login process less synchronous. These dialogs were using exec() to open, which blocked execution on the main applications, which cause general abrupt behavior.
  • Implement proton discovery functions based on valve's own information. Add a dependency on the vdf python library
  • Import UI modules only on relevant platforms

… super-classes

To keep dialogs in a common format and allow them to share the same
properties, three classes of dialogs have been implemented inheriting from
each other.

The classes are `BaseDialog` -> `ButtonDialog` -> `ActionDialog`

* Basedialog: is the basis of all dialogs and is responsible for
rejecting close requests from the window manager and the keyboard.
It also restricts access to `exec()` and `exec_()` because they are harmful.
It serves as the basis of Launch and Login dialogs

* ButtonDialog: is offering buttons for accepting or rejecting the presented
option. It implements its own buttons and exposes abstract methods to
implement handling in them. It restricts access to `close()` because these
dialogs should always product a result.
It is the basis of Uninstall, Selective dialogs.

* ActionDialog: in addition to the ButtonDialog, it offers an action buttom
with to validate the form or to make the dialog unable to close. It serves
as the basis of Install and Move dialogs.
`get_wine_prefixes`: Returns all prefixes defined in legendary's configuration
`get_wine_prefix`: Returns wine prefix associated with a game
…back

* Extend `get_wine_prefix` and `get_wine_prefixes` to take Proton prefixes
into account.
This probably should be split into separate wine and proton
discovery functions.
@loathingKernel loathingKernel merged commit 826d38c into RareDevs:main Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant