No longer enforce staged install #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba14514 to
6491939
Compare
|
Now rebased, my bad for not having refreshed initially with a pull from the repo. |
johnlaing
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRAN came knocking because our package is one of the remaining ones (the other is, <cough, cough> mine too ...) requiring to set
StagedInstall: noinDESCRIPTION. This goes way back to when @jeroen helped us get to the package CRAN-ready and has to do with the fact that we (at the time) opted for absolute paths via@rpathinstructions to the dynamic linker.Well turns out relative ones work too, and @kalibera was of excellent assistance here so this now works. I also sent it to RHub's macOS test instance (that use the CRAN setup, not the one using
brew) and it passed too. This needed changes to no longerSuggests:on the now-departedftspackage, I will send those in subsequent PR.