Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Emafire003
Copy link

@Emafire003 Emafire003 commented Mar 25, 2025

Decied to make a PR with a very basic implementation of the download of the wikis from the moddemc webstite (well, from github technically). As descibed in the issue #6

This checks if a wiki is present on the website, and if it is downloads its repo to a temporary folder, and then creates a resourcepack from it, loading all the files and stuff.

@Rearth Rearth self-assigned this Mar 30, 2025
@Rearth
Copy link
Owner

Rearth commented Mar 30, 2025

Hi, cool stuff, thanks for creating this PR. I'm currently a bit busy with some other stuff and an upcoming vacation, so I currently don't have the time to properly check this out, but will get to it sometime soon. Sorry for leaving this just open for now.

From what I've seen so far in the PR, it checks the loaded mods, and then checks if a matching wiki entry exists, and then downloads the wiki? One issue I see with this is that this will download mod wikis that aren't designed with oracle index in mind. A lot of html formatting just will not work ingame, so some wikis will be displayed wrong.
Maybe we could add an extra step somewhere in the wiki loading pipeline where we check if the mod has a flag set somewhere that actually enables the wiki to be loaded ingame? Some setting on the git repo maybe?

@Emafire003
Copy link
Author

Yeah no problem, this was more like of a proof of concept/starting point thing. For the flagging of the wiki we could either have a custom setting in the fabric.mod.json (or neoforge equivalent) or a file in the repository's folder.
But I would think that the end goal should be supporting most of the tags, and also instead of compleatily disable the wiki from loading a big warning should be displayed. Like "Hey, this could render in a werid way because it isn't fully supported yet" or something like that.

Anyways, I am kinda busy with the exam session too, so no problem on waiting, enjoy your vacation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants