io/Unsigned*.java type conversion fixes#416
Merged
Conversation
UnsignedShort equals accepts any Number but immediately casts to UnsignedNumber, so comparing to Integer, Long, etc. throws ClassCastException, breaking equality contracts and callers that use boxed primitives. UnsignedInt fromBytes(byte[] c, int idx) ignores idx and shifts raw signed bytes without masking. Any non-zero offset or byte with the high bit set returns a corrupted value, so parsing multi-value buffers yields wrong integers. UnsignedShort Same offset/sign issue: ignores idx and shifts signed bytes, producing wrong values for offset reads or bytes >=0x80. UnsignedByte Also ignores the supplied idx and always reads c[0], so attempting to parse from a specific buffer offset returns the wrong byte.
mondain
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit from kdkd fork
7f006faio/object/Unsigned*.java:
UnsignedShort equals accepts any Number but immediately casts to UnsignedNumber, so comparing to Integer, Long,
etc. throws ClassCastException, breaking equality contracts and callers that use boxed primitives.
UnsignedInt fromBytes(byte[] c, int idx) ignores idx and shifts raw signed bytes without masking. Any non-zero
offset or byte with the high bit set returns a corrupted value, so parsing multi-value buffers yields wrong integers.
UnsignedShort Same offset/sign issue: ignores idx and shifts signed bytes, producing wrong values for offset reads
or bytes >=0x80.
UnsignedByte Also ignores the supplied idx and always reads c[0], so attempting to parse from a specific buffer
offset returns the wrong byte.