MOD-9192 Add buffer utils functionality #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/utils/buffer.c
Outdated
| void mr_BufferWriterRewind(mr_BufferWriter* bw) { | ||
| bw->buff->size = 0; | ||
| bw->buff->cap = DEFAULT_INITIAL_CAP; | ||
| bw->buff->buff = MR_REALLOC(bw->buff->buff, DEFAULT_INITIAL_CAP); |
There was a problem hiding this comment.
Better to avoid reuse of the DEFAULT_INITIAL_CAP and use bw->buff->cap here instead.
Also, a question: who frees this buffer? Are there scenarios we get here with an already-allocated buff and can cause a leak?
There was a problem hiding this comment.
yea, no need to realloc the buffer at all.
creation and destruction of buffers should be handled by libMR, the user doesn't need concern themselves with it. aside from that, i'm not sure i understand the question. realloc frees the old allocation if it determines to move to a larger allocation.
There was a problem hiding this comment.
Yes, I misread it as MR_ALLOC()...
galcohen-redislabs
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MOD-9192