Refactor/livewire computed attribute #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase to modernize Livewire computed attributes by replacing the deprecated property-based approach with the new #[Computed] attribute syntax. It also adds Rector Laravel tooling and updates code quality configurations.
- Updates Livewire computed properties to use the new
#[Computed]attribute - Adds Rector Laravel package for automated code improvements
- Fixes a faker method call in OpportunityFactory
Reviewed Changes
Copilot reviewed 7 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/Livewire/UpdateProfileInformationForm.php | Refactors getUserProperty() to user() with #[Computed] attribute |
| composer.json | Adds driftingly/rector-laravel dependency |
| rector.php | Configures Rector with Laravel-specific rules and providers |
| database/factories/OpportunityFactory.php | Adds missing parentheses to faker sentence() method call |
| public/js/filament/tables/tables.js | Updates compiled JavaScript for table functionality |
| public/js/filament/schemas/schemas.js | Updates compiled JavaScript for schema components |
| public/js/filament/schemas/components/actions.js | Updates compiled JavaScript for action components |
Comment on lines
+90
to
+91
| #[Computed] | ||
| public function user(): Authenticatable |
There was a problem hiding this comment.
The method should include an explicit return type declaration. Add : Authenticatable to the method signature to follow PHP 8 type declaration guidelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.