Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix issue 156 add xcg currency support #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

Fix issue 156 add xcg currency support #157

merged 2 commits into from
Apr 30, 2025

Conversation

@lsmilesbd
Copy link
Contributor

@lsmilesbd lsmilesbd commented Apr 2, 2025 •
edited by sourcery-ai bot
Loading

Issue link

Description:

This PR adds support for the XCG (Caribbean Guilder) currency, which replaces the existing ANG (Netherlands Antillean guilder) currency for Curaçao and Sint Maarten. This currency launched as the official currency for Curaçao and Sint Maarten on March 31, 2025.

Changes introduced:

  • Addition of XCG in constants.go
  • Addition of entry for XCG currency in currencies var in file currency.go

Summary by Sourcery

New Features:

  • Add XCG currency to the supported currencies list with its specific formatting and numeric code

lsmilesbd added 2 commits April 2, 2025 09:08
@lsmilesbd
issue-156 update constants.go
40205a7 
add `XCG` currency constant
@lsmilesbd
issue-156 update currency.go
271fc1c 
add entry for XCG Currency
@sourcery-ai
Copy link

sourcery-ai bot commented Apr 2, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request introduces support for the XCG (Caribbean Guilder) currency by adding a new constant and updating the currencies list.

Updated class diagram for the currencies

classDiagram
    class Currencies {
        XAG: Currency
        XAU: Currency
        XCD: Currency
        XCG: Currency
        XDR: Currency
        XOF: Currency
        XPF: Currency
    }
    class Currency {
        Decimal: string
        Thousand: string
        Code: string
        Fraction: int
        NumericCode: string
        Grapheme: string
        Template: string
    }
    Currencies -- Currency : has
Loading

File-Level Changes

Change Details Files
Added support for the XCG currency.
  • Added XCG constant.
  • Added XCG currency entry to the currencies variable.
 constants.go
currency.go
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 2, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lsmilesbd - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a unit test to verify the properties of the new currency.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lsmilesbd
Copy link
Contributor Author

hey @Rhymond Should I be the one to merge this, or will it go out with your next release?

@Rhymond Rhymond merged commit b294798 into Rhymond:master Apr 30, 2025
4 checks passed
@Rhymond
Copy link
Owner

Rhymond commented Apr 30, 2025

hi @lsmilesbd, thanks for the ping, I'm merging and releasing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@Rhymond Rhymond Rhymond approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lsmilesbd @Rhymond