chore: Extract release workflow for automated NuGet package publishing with release-drafter action #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g with release-drafter action
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- .github/workflows/ci.yml: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/release.yml:10
- [nitpick] Consider renaming 'Create Package nuget' to 'Create NuGet Package' for clearer naming conventions.
+ name: Create Package nuget
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- .github/workflows/ci.yml: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/release.yml:35
- [nitpick] Consider renaming the step to 'Build NuGet Package' for improved clarity and consistency.
- name: Build package nuget
.github/workflows/release.yml:42
- [nitpick] For consistency with other steps, consider using the GitHub Actions context syntax (e.g. '${{ env.VERSION }}') instead of '$VERSION' in the push command.
- name: Push package
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- .github/workflows/ci.yml: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/release.yml:43
- [nitpick] Consider quoting the file path that contains the ${{ env.VERSION }} variable to avoid potential issues if the variable ever includes unexpected characters.
run: dotnet nuget push ./output/Netatmo.${{ env.VERSION }}.nupkg -k ${{ secrets.NUGET_ORG_KEY }} -s https://api.nuget.org/v3/index.json
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- .github/workflows/ci.yml: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/release.yml:18
- The parameter expansion in this line is bash-specific; consider explicitly setting the shell to bash in this step to ensure consistent behavior in the future.
tag=${GITHUB_REF/refs\/tags\/}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the GitHub Actions workflows, specifically around the CI and release processes. The most important changes involve the removal of the old CI workflow and the addition of a new release workflow.
Changes to GitHub Actions workflows:
.github/workflows/ci.yml: Removed the entire CI workflow configuration, which included testing on multiple operating systems, building packages, and publishing artifacts..github/workflows/release.yml: Added a new release workflow configuration that triggers on tag pushes, builds and tests the package, and publishes the NuGet package and release artifacts.