Make parentheses optional in ID column type check #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update modifies the regular expression in the satisfies_id_column_requirement? method to make the parentheses in the ID column type optional.
Reason for Change
Previously, the method required the ID column type to include parentheses with digits (e.g., int(10) or bigint(20)), which could exclude valid types like int or bigint without parentheses. The updated regular expression now accommodates these cases, improving flexibility and ensuring that the validation aligns with potential variations in database schema definitions.
Impact
Allows for the validation of both int/bigint types with or without specified lengths.
Prevents unnecessary failures in scenarios where parentheses are omitted in database column definitions.