Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ganeshsbhat
Copy link

This update modifies the regular expression in the satisfies_id_column_requirement? method to make the parentheses in the ID column type optional.

Reason for Change

Previously, the method required the ID column type to include parentheses with digits (e.g., int(10) or bigint(20)), which could exclude valid types like int or bigint without parentheses. The updated regular expression now accommodates these cases, improving flexibility and ensuring that the validation aligns with potential variations in database schema definitions.

Impact

Allows for the validation of both int/bigint types with or without specified lengths.
Prevents unnecessary failures in scenarios where parentheses are omitted in database column definitions.

@jdlombardozzi jdlombardozzi merged commit 6f599d9 into StayNTouch:master Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants