Adding removeField and modifyField to GroupBuilder #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those functions were missing from the Group scope. Liked to issue StoutLogic#82
|
Hey @voyou-sbeaulieu, finally getting around to making updates to the library. Can you add tests to the test suite for this? Just so in the future we don't break things. Thanks |
|
@stevep Sorry for the late reply! Not very familiar with the tests? But I can tell you we already made about ~5 projects with this fix and they all work well no other alteration needed. Just tell me where / what to test and I will surely do it as soon as possible! Thank for your time! |
|
@voyou-sbeaulieu Did you test this change using the latest version? |
|
Hi!
So for the late delay on this ! I was on vacations.
Yes we still use this fix on the latest version I believe.
Le ven. 20 août 2021 18:45, Marcelo ***@***.***> a écrit :
… @voyou-sbeaulieu <https://github.com/voyou-sbeaulieu> Did you test this
change using the latest version?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#91 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEVLJ5RJ4SJTZD6ZK2RGU63T53LKFANCNFSM4H7OYB5Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
|
Thanks for the reply @voyou-sbeaulieu. I added your changes on my end and try to modify a repeater subfield this way and also this way. But it still throw an error. |
stevep
added a commit
that referenced
this pull request
Sep 16, 2021
stevep
added a commit
that referenced
this pull request
Sep 17, 2021
stevep
added a commit
that referenced
this pull request
Sep 17, 2021
…esting. #142 #91 #141 #82 If modifying a Layout (FieldsBuilder), pass updated array config to FieldsBuilder::updateGroupConfig This change also calls removeField and modifyField recursively along the nesting path, so the correct modify / remove action can be taken if running into a Flexible Content field
|
This has been released in version 1.12.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Keep on the good work! We use this logic for all our project now and since we use lots of group / flexible we ran into some problem with the remove / modifyField with groups.
Those functions were missing from the Group scope. linked to issue #82