Allow to use any doctrine 1.y.z #103
Conversation
|
Huh ? The tests succeed but Scrutinizer complains about a non-commited composer.lock, which you removed a while ago. I tried to changed composer update to composer install in CI to make Scrutinizer happy, but with no success. Maybe see scrutinizer-ci/scrutinizer#399 |
|
@guix77 Interesting. Here is the PR where it was removed #68 it seemed to cause problems with other locks, but scrutinizer itself says it shouldn't tie a user to any specific version: https://scrutinizer-ci.com/docs/tools/php/php-analyzer/guides/composer_dependencies Although maybe with the relaxing of the version number from ~1.1 to ~1, it wouldn't cause a conflict? Is there a reason we should use ~1 as opposed to ^1.1 ? |
|
Hi @stevep What's even more intriguing its that this .lock problem is not in the previous accepted PRs. In fact I have to test it but ~1.1 might suffice, I think it's Will test this and update the PR. |
|
Hi Steve, Turns out it was indeed the "doctrine/instantiator": "~1.0**.0**" that was preventing the installation with Themosis, and that ~1.0 is enough. I also reverted the change in .travis.yml since it does not solve the Scrutinizer problem. I'm sorry, I wouldn't know too much why it complains. I've messed up my commits my rushing too much and now there are many, would you like me to consolidate them into one or is it OK like this ? |
|
I think if we do ^1.1 it should be ok and that we can even then include the composer lock file. ^1.1 should allow for 1.3 elsewhere, no? Unless I'm confusing my carrots and tildas |
|
^1.1 for inflector and ^1.0 for instantiator is OK too, yes. To commit composer.lock, intuitively I had the same assumptions as you in #68 (comment) However according to https://scrutinizer-ci.com/docs/tools/php/php-analyzer/guides/composer_dependencies
I'm gonna try to create a project, require the versions 1.1 and then try to install my fork with the commited composer.lock. |
|
All right, this is it... I had to switch to PHP 5.6 and composer install again. Damn Scrutinizer, didn't make this job as quick as I thought! |
|
Thanks so much for figuring this out @guix77 I've squashed and merged it. Will release it as a patch release. |
* allow to use any doctrine 1.y.z * composer install so Scrutinizer is happy * #103 fix doctrine dependencies * Revert "composer install so Scrutinizer is happy" This reverts commit bc0ff93. * #103 fix doctrine instantiator version * #103 dependencies * #103 commit again composer.lock * #103 composer install with php 5.6
|
Thanks a lot @stevep ! |
* allow to use any doctrine 1.y.z * composer install so Scrutinizer is happy * StoutLogic#103 fix doctrine dependencies * Revert "composer install so Scrutinizer is happy" This reverts commit bc0ff93. * StoutLogic#103 fix doctrine instantiator version * StoutLogic#103 dependencies * StoutLogic#103 commit again composer.lock * StoutLogic#103 composer install with php 5.6
Hi,
I'd like to allow to use any doctrine 1.y.z.
Indeed, I'm currently using acf-builder with Themosis (https://framework.themosis.com/), which already has doctrine/ 1.3.z.
Thanks for this great package !