Add test target to SPM package #517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oronbz
reviewed
Sep 18, 2022
Package.swift
Outdated
| path: "Sources"), | ||
| .testTarget(name: "SwinjectTests", | ||
| dependencies: ["Swinject"], | ||
| path: "Tests/SwinjectTests"), |
There was a problem hiding this comment.
Suggested change
| path: "Tests/SwinjectTests"), |
Seems redundant since it's already on the default path.
There was a problem hiding this comment.
Ah thanks for pointing that out, updated the PR to remove the custom path
Docs https://developer.apple.com/documentation/packagedescription/target/path
74df573 to
ef1a751
Compare
maxim-chipeev
approved these changes
Nov 23, 2022
mpdifran
approved these changes
Nov 23, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows running unit tests when loading up the project from the package definition