Exposes object graph #568
Merged
Exposes object graph #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjradfor
approved these changes
May 31, 2024
Sources/Container.swift
Outdated
| let key = ServiceKey(serviceType: Service.self, argumentsType: Arguments.self, name: name, option: option) | ||
|
|
||
| if key == Self.graphIdentifierKey { | ||
| return currentObjectGraph as! Service? |
There was a problem hiding this comment.
We will crash if this cast fails.
Would it make sense to throw an error with a message instead? Or default to a nil Service?
There was a problem hiding this comment.
Sure, I can do that.
But, it should be impossible. The cast is always to GraphIdentifier? as graphIdentifierKey ensures we're making a call to resolve a GraphIdentifier.
If the currentObjectGraph is value nil that will successfully cast to GraphIdentifier?.
Sources/Container.swift
Outdated
| let key = ServiceKey(serviceType: Service.self, argumentsType: Arguments.self, name: name, option: option) | ||
|
|
||
| if key == Self.graphIdentifierKey { | ||
| return currentObjectGraph as! Service? |
There was a problem hiding this comment.
Suggested change
| return currentObjectGraph as! Service? | |
| return currentObjectGraph as? Service |
Has similar runtime performance
0xLucasMarcal
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Faire we use a custom property wrapper
@Resolvedto make Swinject calls (hopefully we can land it in this repo soon), and had to make some significant performance trade-offs to cache the GraphIdentifier without it being properly exposed (involved a workaround using the Lazy wrapper).This one method & a simple ServiceKey check won't cause any change in Swinject native performance but will permit a few powerful use cases. :)