Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kochen
Copy link
Contributor

@kochen kochen commented Sep 4, 2017

Q A
Bug fix? yes
New feature? no
Related tickets fixes #8493
License MIT

@psihius could you confirm is fixes the API issue as well?

@kochen
Copy link
Contributor Author

kochen commented Sep 4, 2017

Sylius\Behat\Page\UnexpectedPageException: Expected to be on "http://localhost:8080/admin/customers/666/edit" but found "http://localhost:8080/admin/login" instead in src/Sylius/Behat/Page/Page.php:132
doesn't seem very related to my fix, is it?

@lchrusciel
Copy link
Contributor

@kochen it is just a random fail, that's why we have behat rerun, these scenarios pass. What you need to fix are the validation responses in API tests. There were 3 failures in CutomerApiTest

@pamil pamil added Potential Bug Potential bugs or bugfixes, that needs to be reproduced. and removed Bug Fix labels Oct 27, 2017
@pamil pamil changed the base branch from master to 1.1 October 2, 2018 15:22
@pamil pamil self-requested a review October 2, 2018 15:23
@pamil
Copy link
Contributor

pamil commented Oct 2, 2018

Trying to revive this PR - rerunning the build on the 1.1 branch.

@pamil pamil merged commit 8c64064 into Sylius:1.1 Oct 3, 2018
@pamil
Copy link
Contributor

pamil commented Oct 3, 2018

Thank you, @kochen! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Potential Bug Potential bugs or bugfixes, that needs to be reproduced.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants