Removed leftover Symfony3 references #9800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
approved these changes
Oct 9, 2018
pamil
suggested changes
Oct 9, 2018
Contributor
pamil
left a comment
There was a problem hiding this comment.
Thank you, just one more quirk needs a fix! :)
| ->setName('sylius:theme:assets:install') | ||
| ->setDefinition([ | ||
| new InputArgument('target', InputArgument::OPTIONAL, 'The target directory', 'web'), | ||
| new InputArgument('target', InputArgument::OPTIONAL, 'The target directory', 'public'), |
Contributor
There was a problem hiding this comment.
This change should be reverted - it's a BC break (it is still possible to use Sylius 1.3 with old directory structure).
Contributor
Author
There was a problem hiding this comment.
I've reverted the default value change.
pamil
approved these changes
Oct 9, 2018
Contributor
|
Thank you, Mitchell! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a few leftover references to Symfony 3.
app.phpandapp_dev.phpare no longer used andwebhas been renamed topublic.