Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Wrong usage of returned data #9829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pamil merged 1 commit into from
Oct 18, 2018
Merged

Wrong usage of returned data #9829

pamil merged 1 commit into from
Oct 18, 2018

Conversation

@Prometee
Copy link
Contributor

@Prometee Prometee commented Oct 15, 2018

getAvailableLocalesCodes return string[] not an object

Q A
Branch? 1.2 1.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets unknown
License MIT

@Prometee Prometee requested a review from a team as a code owner October 15, 2018 12:58
@pamil pamil changed the base branch from master to 1.2 October 18, 2018 11:34
@pamil pamil added Potential Bug Potential bugs or bugfixes, that needs to be reproduced. Documentation Documentation related issues and PRs - requests, fixes, proposals. labels Oct 18, 2018
@Prometee @pamil
Wrong usage of returned data
490bc68 
`getAvailableLocalesCodes` return `string[]` not an object
pamil
pamil approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@pamil pamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased to 1.2 :)

@pamil pamil merged commit ab3a126 into Sylius:1.2 Oct 18, 2018
@pamil
Copy link
Contributor

pamil commented Oct 18, 2018

Thanks, Francis! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pamil pamil pamil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Documentation Documentation related issues and PRs - requests, fixes, proposals. Potential Bug Potential bugs or bugfixes, that needs to be reproduced.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Prometee @pamil