[Core] Bad reverting of ShippingPercentageDiscount promotion #9836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
reviewed
Oct 18, 2018
Contributor
pamil
left a comment
There was a problem hiding this comment.
Would you be willing to provide a Behat scenario to prevent regressions?
c283234 to
c32d391
Compare
Contributor
Author
|
Added. 👍 |
lchrusciel
approved these changes
Oct 22, 2018
lchrusciel
approved these changes
Oct 22, 2018
c32d391 to
2a747c3
Compare
pamil
suggested changes
Oct 22, 2018
Contributor
Author
|
It's because this problem isn't in 1.2. The shipping discount works as expected in 1.2 (even though there is the same line is in the code). |
2a747c3 to
ed8c8ef
Compare
Contributor
|
I'm sorry, you're right, it must be an error that started to happen after we fixed the percentage based promotions. |
ed8c8ef to
9540646
Compare
Contributor
Author
|
No problem :) I updated my branch with latest 1.3. All checks passed. Is it possible to merge now? Let me know if you need anything else to do. Thanks. |
lchrusciel
approved these changes
Oct 26, 2018
Contributor
|
Thanks, @fendrychl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you create a promotion with a discount on delivery, you cannot submit an order.
Steps to reproduce
Create a promotion with "Shipping percentage discount" (set any percents). All orders with applied promotions are unable to finish. After submitting on last step, you will see a "Your order total has been changed, check your order information and confirm it again." message.