Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Roshyo
Copy link
Contributor

@Roshyo Roshyo commented Oct 26, 2018

The previous typing was ok for PHP, but IDE tends to throw an error with this syntax.

Q A
Branch? 1.2
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@Roshyo Roshyo requested a review from a team as a code owner October 26, 2018 12:49
@Roshyo Roshyo changed the title Changing function typing [Order] Changing function typing Oct 26, 2018
The previous typing was ok for PHP, but IDE tends to throw an error with this syntax.
@pamil pamil changed the base branch from master to 1.2 October 29, 2018 10:56
@pamil
Copy link
Contributor

pamil commented Oct 29, 2018

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "patch-3" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@pamil pamil merged commit 095a287 into Sylius:1.2 Oct 29, 2018
@pamil
Copy link
Contributor

pamil commented Oct 29, 2018

Thank you, Stephane! 🥇

@pamil pamil added the Maintenance CI configurations, READMEs, releases, etc. label Oct 29, 2018
@Roshyo Roshyo deleted the patch-3 branch October 29, 2018 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance CI configurations, READMEs, releases, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants