Make use of sylius_core.public_dir in ThemeBundle #9918
Conversation
|
Looks good to me, I've encountered this bug last week and was about to report it. |
| $assetsInstaller->installAssets($input->getArgument('target'), $symlinkMask); | ||
| $targetDir = $this->getContainer()->getParameter('sylius_core.public_dir'); | ||
|
|
||
| if ($input->getArgument('target')) { |
There was a problem hiding this comment.
I'm creating a PR to revert it, since it introduced new bug and i've also missed it in my tests
#9939
|
Updated |
| $targetDir = $input->getArgument('target'); | ||
| } | ||
|
|
||
| return $targetDir; |
There was a problem hiding this comment.
What would you say for something like
if ($input->hasArgument('target')) {
return $input->getArgument('target');
}
return $this->getContainer()->getParameter('sylius_core.public_dir');?
It cleaner, we don't set an unnecessary variable and don't call the container if there is no need.
Btw, I think we don't need these @return string docblocks for new/refactored code (we have return types).
There was a problem hiding this comment.
I'd say we can improve that in another PR. These redundant phpdocs are removed automatically by our CS tool, so there's no need to change it now.
|
Rebased to 1.3, good to merge when green! 🎉 |
|
Thanks, @alekseyp! 🥇 |
That should fix that reverted commit - Sylius/SyliusThemeBundle@108455f