Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make build great again (one more time) #9971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Zales0123 merged 1 commit into from
Nov 27, 2018
Merged

Make build great again (one more time) #9971

Zales0123 merged 1 commit into from
Nov 27, 2018

Conversation

@Zales0123
Copy link
Contributor

@Zales0123 Zales0123 commented Nov 27, 2018

Q A
Branch? 1.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets related with #9970
License MIT

As in the previous PR, we need to disable (for now) some specific versions of some specific packages. "symfony/symfony": "3.4.7 || 4.0.7 || 4.1.8" does not work anymore, as we don't use symfony/symfony since Sylius 1.3 :)

@Zales0123 Zales0123 added Potential Bug Potential bugs or bugfixes, that needs to be reproduced. Maintenance CI configurations, READMEs, releases, etc. labels Nov 27, 2018
@Zales0123 Zales0123 requested a review from a team as a code owner November 27, 2018 14:58
@Zales0123 Zales0123 changed the base branch from master to 1.3 November 27, 2018 14:58
@Zales0123 Zales0123 merged commit 4166cf8 into Sylius:1.3 Nov 27, 2018
@Zales0123 Zales0123 deleted the fix-build-on-1.3 branch November 27, 2018 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Maintenance CI configurations, READMEs, releases, etc. Potential Bug Potential bugs or bugfixes, that needs to be reproduced.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Zales0123